Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: explore options to check local container status before running tests #2005

Closed
shantuo opened this issue May 6, 2019 · 2 comments · Fixed by #2029
Closed

testing: explore options to check local container status before running tests #2005

shantuo opened this issue May 6, 2019 · 2 comments · Fixed by #2029
Assignees
Labels
code health Code health task, either refactoring or testing P1

Comments

@shantuo
Copy link
Contributor

shantuo commented May 6, 2019

We discussed in the vault PR that we want to get a sync point after localXXX.sh boots a container of a certain server for testing.

There are a few options:

  1. Do nothing more, we set a timeout on the constructors and fail if the server is not up after a few seconds.
  2. Wait a few seconds after the container starts and check its health.
  3. If the previous one is still flaky, write a Go program to do more proper waiting.
@shantuo shantuo added the code health Code health task, either refactoring or testing label May 6, 2019
@shantuo
Copy link
Contributor Author

shantuo commented May 6, 2019

For Travis runs, we should detect and run these local tests on Linux only. Currently we skip the tests because the mac builds don't have these containers running, we should remove the Skip part.

@eliben eliben added the P1 label May 8, 2019
@eliben
Copy link
Member

eliben commented May 8, 2019

@shantuo I'm raising the priority of this since I'm concerned we're not testing a bunch of code in all scenarios as long as we're skipping by default. There shouldn't be anything blocking this right now, correct me if I'm wrong

@shantuo shantuo added the in progress This is being actively worked on label May 8, 2019
@go-cloud-bot go-cloud-bot bot removed the in progress This is being actively worked on label May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Code health task, either refactoring or testing P1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants