secrets/vault: run tests against a vault docker container #1983
Conversation
|
Also related to #886 |
There was a problem hiding this comment.
Awesome, thanks for fixing this quickly! I'd double check with @zombiezen for the docker-y stuff
Codecov Report
@@ Coverage Diff @@
## master #1983 +/- ##
==========================================
- Coverage 77.63% 77.49% -0.15%
==========================================
Files 82 82
Lines 9566 9566
==========================================
- Hits 7427 7413 -14
- Misses 1607 1621 +14
Partials 532 532
Continue to review full report at Codecov.
|
| "gocloud.dev/secrets" | ||
| "gocloud.dev/secrets/driver" | ||
| "gocloud.dev/secrets/drivertest" | ||
| ) | ||
|
|
||
| // To run these tests against a real Vault server, first run ./localvault.sh. | ||
| // Then wait a few seconds for the server to be ready. |
There was a problem hiding this comment.
Is there a way we can health check it for readiness? Or perhaps dial-looping for some period of time? This seems like a source of flakiness.
There was a problem hiding this comment.
The default client has 2 max retries and 60-second timeout. I changed it to 3 max retries with 3-second timeout for local testing.
There was a problem hiding this comment.
Gotcha. I do wonder whether start_local_deps.sh or localvault.sh should wait for a healthy response before continuing with the tests.
There was a problem hiding this comment.
Yeah I thought about doing some checks on the server health and retries. But I think it is hard to know whether we should restart the container or wait longer for the health probe. It would become as flaky. That's why I did more retries when dialing the test server and skip the test after a few attempts. WDYT?
There was a problem hiding this comment.
What I'm saying is: the test is using presence of server to determine whether to run the test, so that should fail fast. The localvault.sh script should block on health checks before coming up. This is likely a problem with all current local dep scripts, so it would be fine to file an issue and handle it separately. In the meantime, I think these tests should fail fast.
| "gocloud.dev/secrets" | ||
| "gocloud.dev/secrets/driver" | ||
| "gocloud.dev/secrets/drivertest" | ||
| ) | ||
|
|
||
| // To run these tests against a real Vault server, first run ./localvault.sh. | ||
| // Then wait a few seconds for the server to be ready. |
There was a problem hiding this comment.
The default client has 2 max retries and 60-second timeout. I changed it to 3 max retries with 3-second timeout for local testing.
Fixes #1958