Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add filen linter (#5081)" #5087

Merged
merged 1 commit into from
Oct 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions .golangci.next.reference.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ linters:
- exhaustruct
- exportloopref
- fatcontext
- filen
- forbidigo
- forcetypeassert
- funlen
Expand Down Expand Up @@ -153,7 +152,6 @@ linters:
- exhaustruct
- exportloopref
- fatcontext
- filen
- forbidigo
- forcetypeassert
- funlen
Expand Down Expand Up @@ -536,17 +534,6 @@ linters-settings:
exclude:
- '.+/cobra\.Command$'

filen:
# Ignore comments when counting lines.
# Default false
ignore-comments: true
# Max number of lines in a file.
# Default: 1000
max-lines: 500
# Min number of lines in a file.
# Default: 5
min-lines: 1

forbidigo:
# Forbid the following identifiers (list of regexp).
# Default: ["^(fmt\\.Print(|f|ln)|print|println)$"]
Expand Down
1 change: 0 additions & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ require (
github.com/Antonboom/testifylint v1.5.0
github.com/BurntSushi/toml v1.4.1-0.20240526193622-a339e1f7089c
github.com/Crocmagnon/fatcontext v0.5.2
github.com/DanilXO/filen v0.3.0
github.com/Djarvur/go-err113 v0.0.0-20210108212216-aea10b59be24
github.com/GaijinEntertainment/go-exhaustruct/v3 v3.3.0
github.com/OpenPeeDeeP/depguard/v2 v2.2.0
Expand Down
2 changes: 0 additions & 2 deletions go.sum

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 0 additions & 21 deletions jsonschema/golangci.next.jsonschema.json
Original file line number Diff line number Diff line change
Expand Up @@ -1012,27 +1012,6 @@
}
}
},
"filen": {
"type": "object",
"additionalProperties": false,
"properties": {
"ignore-comments": {
"description": "Ignore comments when counting lines.",
"type": "boolean",
"default": false
},
"max-lines": {
"description": "Max number of lines in a file.",
"type": "integer",
"default": 1000
},
"min-lines": {
"description": "Min number of lines in a file.",
"type": "integer",
"default": 5
}
}
},
"forbidigo": {
"type": "object",
"additionalProperties": false,
Expand Down
12 changes: 0 additions & 12 deletions pkg/config/linters_settings.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,6 @@ var defaultLintersSettings = LintersSettings{
ExplicitExhaustiveMap: false,
ExplicitExhaustiveSwitch: false,
},
Filen: FilenSettings{
MinLines: 5,
MaxLines: 1000,
IgnoreComments: false,
},
Forbidigo: ForbidigoSettings{
ExcludeGodocExamples: true,
},
Expand Down Expand Up @@ -219,7 +214,6 @@ type LintersSettings struct {
ErrorLint ErrorLintSettings
Exhaustive ExhaustiveSettings
Exhaustruct ExhaustructSettings
Filen FilenSettings
Forbidigo ForbidigoSettings
Funlen FunlenSettings
Gci GciSettings
Expand Down Expand Up @@ -424,12 +418,6 @@ type ExhaustructSettings struct {
Exclude []string `mapstructure:"exclude"`
}

type FilenSettings struct {
IgnoreComments bool `mapstructure:"ignore-comments"`
MaxLines int `mapstructure:"max-lines"`
MinLines int `mapstructure:"min-lines"`
}

type ForbidigoSettings struct {
Forbid []ForbidigoPattern `mapstructure:"forbid"`
ExcludeGodocExamples bool `mapstructure:"exclude-godoc-examples"`
Expand Down
24 changes: 0 additions & 24 deletions pkg/golinters/filen/filen.go

This file was deleted.

11 changes: 0 additions & 11 deletions pkg/golinters/filen/filen_integration_test.go

This file was deleted.

Loading
Loading