Revert "Add filen linter (#5081)" #5087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 29c5529.
ldez
added
enhancement
alexandear
approved these changes
Oct 27, 2024
|
The fact the revive PR would lead to duplicate rules is the reason why I posted my comment. I agree with your decision |
|
The main thing is that the need for file size limitation is closed. It's okay that PR was reverted, the experience of creating a linter was interesting and curious for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the PR mgechev/revive#1072 has been merged into revive, and as
filenis not in a released version of golangci-lint, we should remove this linter because it becomes a duplicate linter.If we don't remove it now, we will deprecate it after the release, so it's better to remove it now.
@DanilXO I'm sorry, it was unexpected to me that, after 2 years without a real reaction to the discussion, someone created a PR to add this rule to revive.
I'm not really happy that someone uses your linter and your PR as references to create a rule inside revive. Communication should be a priority and it should be improved.
But anyway, what is done is done.
Related to #5081
This reverts commit 29c5529.