Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gocritic #353

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Update gocritic #353

merged 1 commit into from
Jan 9, 2019

Conversation

jirfag
Copy link
Member

@jirfag jirfag commented Jan 8, 2019

Fix #324, relates #314

  1. Update gocritic to the latest version
  2. Use proper gocritic checkers repo, old repo was archived
  3. Get enabled by default gocritic checks in sync with go-critic: don't
    enable performance, experimental and opinionated checks by default
  4. Support of enabled-tags options for gocritic
  5. Enable almost all gocritic checks for the project
  6. Make rich debugging for gocritic
  7. Meticulously validate gocritic checks config

@jirfag
Copy link
Member Author

jirfag commented Jan 8, 2019

/cc @quasilyte

Fix #324, relates #314

1. Update gocritic to the latest version
2. Use proper gocritic checkers repo, old repo was archived
3. Get enabled by default gocritic checks in sync with go-critic: don't
enable performance, experimental and opinionated checks by default
4. Support of `enabled-tags` options for gocritic
5. Enable almost all gocritic checks for the project
6. Make rich debugging for gocritic
7. Meticulously validate gocritic checks config
@jirfag jirfag force-pushed the feature/update-gocritic branch from 4e3255d to 749cdb2 Compare January 9, 2019 06:40
@jirfag jirfag merged commit 87aae77 into master Jan 9, 2019
@jirfag jirfag deleted the feature/update-gocritic branch January 9, 2019 06:51
@ldez ldez added this to the v1.13 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support gocritic tags
2 participants