Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support gocritic tags #324

Closed
lopezator opened this issue Dec 20, 2018 · 2 comments · Fixed by #353
Closed

Support gocritic tags #324

lopezator opened this issue Dec 20, 2018 · 2 comments · Fixed by #353

Comments

@lopezator
Copy link
Member

lopezator commented Dec 20, 2018 •
edited
Loading

Instead of having to add each specific enabled check inside gocritic (which could be painful for newcomers), isn't a way to add groups of checks (called tags) like #performance, #style...?

If this isn't implemented yet I think it would be very interesting.

Reference:

https://github.com/go-critic/go-critic#usage -> section "Tags"
@jirfag
Copy link
Member

jirfag commented Jan 8, 2019

hi! I agree it may be a useful feature. But I'm not sure it will be common-used: I didn't see users using the same concept of tags in golangci-lint itself.
Pull requests are welcome

jirfag added a commit that referenced this issue Jan 8, 2019
@jirfag
Update gocritic
dba8bdc 
Fix #324, relates #314

1. Update gocritic to the latest version
2. Use proper gocritic checkers repo, old repo was archived
3. Get enabled by default gocritic checks in sync with go-critic: don't
enable performance, experimental and opinionated checks by default
4. Support of `enabled-tags` options for gocritic
5. Enable almost all gocritic checks for the project
6. Make rich debugging for gocritic
7. Meticulously validate gocritic checks config
@jirfag jirfag mentioned this issue Jan 8, 2019
Merged
@jirfag
Copy link
Member

jirfag commented Jan 8, 2019 •
edited
Loading

I've supported gocritic tags in the linked pull request.

jirfag added a commit that referenced this issue Jan 9, 2019
@jirfag
Update gocritic
4e3255d 
Fix #324, relates #314

1. Update gocritic to the latest version
2. Use proper gocritic checkers repo, old repo was archived
3. Get enabled by default gocritic checks in sync with go-critic: don't
enable performance, experimental and opinionated checks by default
4. Support of `enabled-tags` options for gocritic
5. Enable almost all gocritic checks for the project
6. Make rich debugging for gocritic
7. Meticulously validate gocritic checks config
jirfag added a commit that referenced this issue Jan 9, 2019
@jirfag
Update gocritic
749cdb2 
Fix #324, relates #314

1. Update gocritic to the latest version
2. Use proper gocritic checkers repo, old repo was archived
3. Get enabled by default gocritic checks in sync with go-critic: don't
enable performance, experimental and opinionated checks by default
4. Support of `enabled-tags` options for gocritic
5. Enable almost all gocritic checks for the project
6. Make rich debugging for gocritic
7. Meticulously validate gocritic checks config
jirfag added a commit that referenced this issue Jan 9, 2019
@jirfag
Update gocritic
87aae77 
Fix #324, relates #314

1. Update gocritic to the latest version
2. Use proper gocritic checkers repo, old repo was archived
3. Get enabled by default gocritic checks in sync with go-critic: don't
enable performance, experimental and opinionated checks by default
4. Support of `enabled-tags` options for gocritic
5. Enable almost all gocritic checks for the project
6. Make rich debugging for gocritic
7. Meticulously validate gocritic checks config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update gocritic golangci/golangci-lint
2 participants
@jirfag @lopezator