Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect cast when animating int #81296

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Fix incorrect cast when animating int #81296

merged 1 commit into from
Sep 5, 2023

Conversation

AThousandShips
Copy link
Member

Type was cast to int rather than int64_t

@AThousandShips AThousandShips added bug topic:animation cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Sep 4, 2023
@AThousandShips AThousandShips added this to the 4.2 milestone Sep 4, 2023
@AThousandShips AThousandShips requested a review from a team September 4, 2023 09:06
@AThousandShips
Fix incorrect cast when animating int
035cf5e 
Type was cast to `int` rather than `int64_t`
Also corrects `real_t` to `double`
akien-mga
akien-mga approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@AThousandShips
Copy link
Member Author

Tween also uses real_t in some odd places, might be able to take a look later

@YuriSizov YuriSizov merged commit cfdc016 into godotengine:master Sep 5, 2023
16 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@AThousandShips
Copy link
Member Author

Thank you!

@AThousandShips AThousandShips deleted the blend_fix branch September 5, 2023 13:22
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 24, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.3.

@AThousandShips AThousandShips mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:animation
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

C# method tweens can't handle 64 bit integer types
3 participants
@AThousandShips @YuriSizov @akien-mga