Fix linear interpolation not working with mixed (int/float) keyframes #86046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bs-mwoerner
force-pushed
the
linear_animation_typemix
branch
from
502790f to
26126bd
Compare
TokageItLab
requested changes
Dec 12, 2023
bs-mwoerner
force-pushed
the
linear_animation_typemix
branch
from
26126bd to
88c4820
Compare
TokageItLab
requested changes
Dec 12, 2023
…eger and float keyframes.
bs-mwoerner
force-pushed
the
linear_animation_typemix
branch
from
88c4820 to
12ce2e3
Compare
TokageItLab
approved these changes
Dec 12, 2023
akien-mga
added
cherrypick:4.2
AThousandShips
approved these changes
Dec 13, 2023
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.2
|
Cherry-picked for 4.2.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85858.
It is possible in the editor to create both integer and float keyframes on an animation track. With the rework of variant interpolation and blending (#84815), linear interpolation lost its ability to interpolate between such keyframes (cubic interpolation works). This PR restores a special case handling for int/float pairs similar to what was there before the rework.