Add TRANS_SPRING interpolation option to tweens
#64680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriSizov
changed the title
TRANS_SPRING interpolation option to tweens
TokageItLab
reviewed
Aug 21, 2022
|
You used your master branch again... You will likely have issues again when you start making changes after the review or need to rebase. And with that, please use a more descriptive commit message, e.g. what I changed the title to. |
TokageItLab
reviewed
Aug 21, 2022
scene/animation/tween.cpp
Outdated
| @@ -45,6 +45,7 @@ Tween::interpolater Tween::interpolaters[Tween::TRANS_MAX][Tween::EASE_MAX] = { | |||
| { &circ::in, &circ::out, &circ::in_out, &circ::out_in }, | |||
| { &bounce::in, &bounce::out, &bounce::in_out, &bounce::out_in }, | |||
| { &back::in, &back::out, &back::in_out, &back::out_in }, | |||
| { &spring::out, &spring::out, &spring::out, &spring::out }, // Spring is the same for each easing. | |||
There was a problem hiding this comment.
As I said above, I think this comment is probably a wrong. It should be possible to implement in/out/inout/outin the same way as Bounce.
There was a problem hiding this comment.
Not sure what you mean by "the same as Bounce", but in the previous PR it was settled that it's ok if spring implements single easing IF it's documented. Not sure if bounce fits here this way.
rakkarage
force-pushed
the
master
branch
2 times, most recently
from
59d0457 to
e382216
Compare
Merged
|
github misleading us once again? |
|
Yes... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for all the help! I hope everything is now in order.
my proposal: godotengine/godot-proposals#4212
my other attempt at a pull request: #58999
Production edit: Closes godotengine/godot-proposals#4212