-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] Remove hardcoded names in generated objects #47279
Conversation
71cb8d3
to
c58391c
Compare
Force pushed to solve merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fine to merge like the master
PR was.
Thanks! |
FYI this is a breaking change for some workflows.. If you have created a new inherited scene , and then modified node properties. When updating to 3.5 the inherited scene will no longer modify the properties of the correct child object. (the name of the modified node is now incorrect) Probably should mention this in the release notes. |
Can you also post this in the documentation team so it doesn't get lost? I'm currently at Siggraph 2022. |
It is mentioned in the curated changelog: https://github.com/godotengine/godot/blob/3.5/CHANGELOG.md#import |
It's mentioned, but there's no note that it's a breaking change like some other changes.. |
This is a 3.x version of #47271.