Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Remove hardcoded names in generated objects #47279

Merged
merged 1 commit into from
Jul 2, 2022
Merged

[3.x] Remove hardcoded names in generated objects #47279

merged 1 commit into from
Jul 2, 2022

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Mar 22, 2021

This is a 3.x version of #47271.

@Shatur Shatur requested a review from a team as a code owner March 22, 2021 22:55
@akien-mga akien-mga added this to the 3.4 milestone Mar 23, 2021
@Chaosus Chaosus modified the milestones: 3.4, 3.5 Nov 8, 2021
@akien-mga akien-mga force-pushed the 3.x branch 2 times, most recently from 71cb8d3 to c58391c Compare January 6, 2022 22:40
@akien-mga
Copy link
Member

Force pushed to solve merge conflicts.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine to merge like the master PR was.

@akien-mga akien-mga merged commit 498334d into godotengine:3.x Jul 2, 2022
@akien-mga
Copy link
Member

Thanks!

@jamie-pate
Copy link
Contributor

jamie-pate commented Aug 10, 2022

FYI this is a breaking change for some workflows..

If you have created a new inherited scene , and then modified node properties. When updating to 3.5 the inherited scene will no longer modify the properties of the correct child object. (the name of the modified node is now incorrect)
(e.g. there's no xyz-rigid then it used to be named 'mesh' but now it's 'xyz-rigid'. In my case it's useful to hide this rigid body who's mesh should not be shown since there's no xyz-rigidcolonly import modifier pattern)

Probably should mention this in the release notes.

@fire

@fire
Copy link
Member

fire commented Aug 10, 2022

Can you also post this in the documentation team so it doesn't get lost? I'm currently at Siggraph 2022.

@akien-mga
Copy link
Member

It is mentioned in the curated changelog: https://github.com/godotengine/godot/blob/3.5/CHANGELOG.md#import

@jamie-pate
Copy link
Contributor

jamie-pate commented Aug 10, 2022

It is mentioned in the curated changelog: https://github.com/godotengine/godot/blob/3.5/CHANGELOG.md#import

It's mentioned, but there's no note that it's a breaking change like some other changes..
(I commented on the commit earlier (rc6) but I guess that comment got lost since it wasn't on the PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants