Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the copy_mono_root SCons option by default #42332

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Sep 25, 2020

This closes #41652.

@Calinou Calinou requested a review from neikeq as a code owner September 25, 2020 09:07
@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:buildsystem topic:dotnet labels Sep 25, 2020
@Calinou Calinou added this to the 4.0 milestone Sep 25, 2020
@Calinou Calinou force-pushed the default-enable-copy-mono-root branch from 5fd93f2 to cfd564b Compare September 25, 2020 09:08
@akien-mga akien-mga merged commit ed91d3e into godotengine:master Sep 25, 2020
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.2.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Sep 25, 2020
@akien-mga
Copy link
Member

I don't get why the black format check passed in the PR but not once merged...

@akien-mga
Copy link
Member

Actually there was no CI build for this PR :|

akien-mga added a commit that referenced this pull request Sep 25, 2020
Somehow it did not run CI checks so we missed that one.

Also pin `black` version to latest upstream release.
@Calinou Calinou deleted the default-enable-copy-mono-root branch September 30, 2020 20:46
MarcusElg pushed a commit to MarcusElg/godot that referenced this pull request Oct 19, 2020
Somehow it did not run CI checks so we missed that one.

Also pin `black` version to latest upstream release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The assembly mscorlib.dll was not found or could not be loaded
3 participants