Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] use owner and repo name for workspace id #7390

Closed

Conversation

svenefftinge
Copy link
Member

@svenefftinge svenefftinge commented Dec 30, 2021

This change introduces optional arguments in generateWorkspaceId
for the first two segments. And makes use of it in workspace factory
using the repos org/group and name.

fixes #4129

Testing

Start a workspace on GitHub and GitLab repos (try with nested groups on GitLab) and find the repo names and orgs reflected in the workspace id.

Release Notes

Use repository org and name for workspace ids.

This change introduces optional arguments in generateWorkspaceId
for the first two segments. And makes use of it in workspace factory
using the repos org/group and name.

fixes #4129
@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jldec after the PR has been reviewed.
You can assign the PR to them by writing /assign @jldec in a comment when ready.

Associated issue: #4129

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@svenefftinge
Copy link
Member Author

svenefftinge commented Dec 30, 2021

Closing because the branch name is too long to get deployed 🙄

@svenefftinge svenefftinge deleted the sefftinge/please-use-a-useful-workspace-4129 branch December 30, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please use a useful workspace name instead of a nonsensical one
2 participants