-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please use a useful workspace name instead of a nonsensical one #4129
Comments
This definitely needs feedback from @svenefftinge; wdyt? (removing from groundwork until this becomes actionable) |
I think it's a good improvement. We currently have two name segments followed by 8 characters to make the workspace unique. Since seeing my username as the first segment wouldn't help me to distinguish workspaces, I propose to leave that out. We can change the name function so that you can optionally pass in two segments that match the regexp For git-based workspaces we can then generate names using org followed by the repo-name. e.g.: |
We just had another discussion on this. To make sure we are moving in the right direction I'd like to understand what you wrote here:
Assuming that the problem to solve is distinguishing workspaces based on the URL, I don't see how this pattern helps, because
I can only see this becoming more helpfully once we add information that really separates workspaces from each other (e.g. context, such as mr/pr, issue, branch). But encoding all this into the URL doesn't seem great either. So would it help if we were surfacing the workspace description (derived from context) a bit more again? I'm thinking about showing the workspace description in the browser tab again and also allow editing it. |
I welcome editing the name, it would help. But a default name that's meaningful is superb to start with. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
To me this is still really important. I think you could add a little information to the URL and make gitpod hugely more valuable. |
Thanks for keeping this alive @rfay. You might be right that my hypothesis is not accurate. So I'd vote for doing as described in #4129 (comment) cc @jldec |
Thanks for raising @rfay! I've seen some other issues on this topic that I think have the same underlying issue, but with different proposed solutions. So I wanted to throw in a couple alternative / additional solutions / thoughts:
Note: From a usability session [1], a user did also raise that they'd like to customise their URL's but the context/problem was a little different, i.e the user wanted to have more static URL's to make sharing them / remembering them more easily. |
This change introduces optional arguments in generateWorkspaceId for the first two segments. And makes use of it in workspace factory using the repos org/group and name. fixes #4129
This change introduces optional arguments in generateWorkspaceId for the first two segments. And makes use of it in workspace factory using the repos org/group and name. fixes #4129
This change introduces optional arguments in generateWorkspaceId for the first two segments. And makes use of it in workspace factory using the repos org/group and name. fixes #4129
This change introduces optional arguments in generateWorkspaceId for the first two segments. And makes use of it in workspace factory using the repos org/group and name. fixes #4129
This change introduces optional arguments in generateWorkspaceId for the first two segments. And makes use of it in workspace factory using the repos org/group and name. fixes #4129
This change introduces optional arguments in generateWorkspaceId for the first two segments. And makes use of it in workspace factory using the repos org/group and name. fixes #4129
Thanks for this! It's a great step forward.
|
Thank you for getting this fixed! It's great. I found a bug with repos that contain capital letters (ie. DrupalPod), and found the fix for that was already committed today :) How can we tell when will this fix be deployed to live Gitpod workspaces? |
Next deployment is planned for Tuesday 9am CET
Sent via Superhuman iOS ***@***.***>
…On Sat, Jan 15 2022 at 4:47 AM, Ofer Shaal ***@***.***> wrote:
Thank you for getting this fixed! It's great.
I found a bug with repos that contain capital letters (ie. DrupalPod), and
found the fix for that was already committed today :)
5550be1
<5550be1>
How can we tell when will this fix be deployed to live Gitpod workspaces?
—
Reply to this email directly, view it on GitHub
<#4129 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC4HGDBSVRSYLU6FOR4IW3UWDU37ANCNFSM436UNNWQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you commented.Message ID:
***@***.***>
|
I never can figure out what is in a tab without looking at the code. Instead of a nonsensical name like
https://purple-scorpion-d98aj3rj.ws-us04.gitpod.io/
could we have one that hints at the contents?So for example, if I open up github.com/drud/ddev with GitHub Codespaces I get a URL like this:
https://rfay-drud-ddev-479f.github.dev/
- it indicates that it's owned by rfay, and is drud/ddev at 479f. Nice. Thanks! Solves several other name-related complaints here like #3908Thanks for gitpod! It's amazing.
The text was updated successfully, but these errors were encountered: