Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Installer]: configure endpoint/region of registry S3 backing #10577

Merged
merged 2 commits into from
Jun 13, 2022
Merged

[Installer]: configure endpoint/region of registry S3 backing #10577

merged 2 commits into from
Jun 13, 2022

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Jun 10, 2022

Description

There is no way to independently control the bucket configuration for the main S3 bucket and the registry's S3 backing. This introduces the configuration surface in the Installer and implements it in the KOTS installer. The registry persistence is also disabled if the S3 backing is used - this never becomes ready, so causes Helm to timeout.

There is at least one customer blocked by this. If the object storage wasn't configured and the registry S3 was, it also prevented the Helm install job from ever finishing - see internal discussion.

Related Issue(s)

Fixes #9800

How to test

Configure S3 backing for registry and the main object storage using the in-cluster option.

I have checked that there's no regression in the in-cluster repo too

Release Notes

[Installer]: configure endpoint/region of registry S3 backing

Documentation

@mrsimonemms mrsimonemms changed the title Sje/registry s3 [Installer]: configure endpoint/region of registry S3 backing Jun 10, 2022
@mrsimonemms
Copy link
Contributor Author

mrsimonemms commented Jun 10, 2022

/werft no-preview publish-to-kots

👎 unknown command: no-preview
Use /werft help to list the available commands

@mrsimonemms
Copy link
Contributor Author

mrsimonemms commented Jun 10, 2022

/werft run no-preview publish-to-kots

👍 started the job as gitpod-build-sje-registry-s3-fork.0
(with .werft/ from main)

@mrsimonemms
Copy link
Contributor Author

mrsimonemms commented Jun 10, 2022

/werft run no-preview publish-to-kots

👍 started the job as gitpod-build-sje-registry-s3-fork.1
(with .werft/ from main)

@mrsimonemms
Copy link
Contributor Author

mrsimonemms commented Jun 10, 2022

/werft run no-preview publish-to-kots

👍 started the job as gitpod-build-sje-registry-s3-fork.2
(with .werft/ from main)

@mrsimonemms mrsimonemms marked this pull request as ready for review June 10, 2022 10:55
@mrsimonemms mrsimonemms requested a review from a team June 10, 2022 10:55
@mrsimonemms
Copy link
Contributor Author

This covers some of the same ground as #10208 by @nandajavarma

@nandajavarma
Copy link
Contributor

@mrsimonemms This works well! Just that now that the openSSH install PR is in, this is conflicting. Could you resolve this with a rebase?

@nandajavarma nandajavarma added the team: delivery Issue belongs to the self-hosted team label Jun 13, 2022
@mrsimonemms
Copy link
Contributor Author

mrsimonemms commented Jun 13, 2022

/werft run no-preview publish-to-kots

👍 started the job as gitpod-build-sje-registry-s3-fork.3
(with .werft/ from main)

Copy link
Contributor

@nandajavarma nandajavarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@roboquat roboquat merged commit 3c10cc0 into gitpod-io:main Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/M team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KOTS incluster registry S3 dialog doesn't request region
3 participants