KOTS incluster registry S3 dialog doesn't request region

[mrzarquon]

Bug description

The S3 region defaults to "local" in the installation if one is just using S3 for the the registry backend and not anything else. In order to fix this, the deployment can be edited by hand, but a subsequent redeployment by kots when changing other settings will remove the change.

Introduced by #9701

Steps to reproduce

Install in AWS using the getting starting guide and provide S3 credentials for the incluster registry.

kubectl edit deployment registry -n gitpod

Change region to correct region, restart just the registry deployment and it works, but doing a redeployment if making another change (or updating) will revert the change.

Workspace affected

No response

Expected behavior

No response

Example repository

No response

Anything else?

No response

[mrsimonemms]

This is caused by the separation of the S3 credentials between the object store and the registry - originally, these were linked but now they are (correctly) made independent.

How to fix this ticket:

1. add a region and endpoint param to the S3Storage struct
2. add the region and endpoint param to the KOTS config

NB I'm proposing adding the endpoint (and defaulting to s3.amazonaws.com) to avoid any problems when we eventually get a customer who wants to use an S3 compatible storage in not-AWS - IT WILL HAPPEN

This is causing a customer issue, so I will look at this in next 24 hours. @jimmybrancaccio is liaising with customer and had a test instance all set up

IMPORTANT once this is in main, we should cut a KOTS hotfix release with this in it