Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add info about convert tasks into issues #29247

Merged
merged 11 commits into from
Oct 24, 2023

Conversation

CBID2
Copy link
Contributor

@CBID2 CBID2 commented Oct 19, 2023

Why:

This PR adds a section on how to convert tasks created on issues into their own issues. This helps maintainers learn another way to organize their issues.

Closes:

Closes #24862

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
get-started/writing-on-github/working-with-advanced-formatting/about-task-lists.md fpt
ghec
ghes@ 3.10 3.9
fpt
ghec
ghes@ 3.10 3.9

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@CBID2
Copy link
Contributor Author

CBID2 commented Oct 19, 2023

Hi @cmwilson21! :) As promised, I made the PR.

@cmwilson21
Copy link
Contributor

👋 @CBID2 excellant! Thanks for the PR, I'll get it up for review ✨

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review get started Content related to "Getting Started" doc set and removed triage Do not begin working on this issue until triaged by the team labels Oct 19, 2023
@mchammer01 mchammer01 self-requested a review October 20, 2023 08:34
@CBID2
Copy link
Contributor Author

CBID2 commented Oct 20, 2023

Ummm @mchammer01 & @cmwilson21, all of the tests failed.

Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try and fix the check failures.

@mchammer01
Copy link
Contributor

I'll unassign myself for now, until we decide how to proceed with this PR.
@CBID2 - I do believe I fixed the check failures 😃

@mchammer01 mchammer01 requested review from mchammer01 and removed request for mchammer01 October 20, 2023 14:41
@CBID2
Copy link
Contributor Author

CBID2 commented Oct 20, 2023

I'll unassign myself for now, until we decide how to proceed with this PR.

@CBID2 - I do believe I fixed the check failures 😃

Yup you did. If you're a maintainer, I think you can approve of it.

@mchammer01
Copy link
Contributor

mchammer01 commented Oct 20, 2023

@CBID2 👋🏻 - thanks for your note. I haven't reviewed your PR yet because I think, although it looks good, and contains a useful new procedural section, it doesn't answer the part of the issue that mention explaining what conditions must be met to show the hover icon to create issue behind tasklist items. I have ask folks who are more familiar with task lists than me if they can help.
Thanks for your patience with us ❤️

Copy link
Contributor

@guntrip guntrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @CBID2, thanks so much for picking this up! ✨

It looks like Felicity tested for reasons the icon might not appear in the associated issue and didn't find any.

I made a few little changes via a suggested comment, and included the octicon directly rather than describing it which I think will make this procedural more accessible; the octicon includes the same alt text as the UI, so a screenreader will describe it in the same way.

We've got two unrelated test failures, for our API docs. I'll see if this will merge, if not, I'll ask our engineers to take a look.

Thank you again! ✨

@guntrip guntrip added hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! ready to merge This pull request is ready to merge labels Oct 24, 2023
@guntrip guntrip enabled auto-merge October 24, 2023 12:56
@guntrip guntrip added this pull request to the merge queue Oct 24, 2023
Merged via the queue into github:main with commit 9791cdc Oct 24, 2023
42 checks passed
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@CBID2 CBID2 deleted the adding-information-about-conditions branch October 24, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team get started Content related to "Getting Started" doc set hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explain what conditions must be met to show hover icon to create issue behind tasklist items
4 participants