-
Notifications
You must be signed in to change notification settings - Fork 60.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add info about convert tasks into issues #29247
feat: add info about convert tasks into issues #29247
Conversation
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
Hi @cmwilson21! :) As promised, I made the PR. |
👋 @CBID2 excellant! Thanks for the PR, I'll get it up for review ✨ |
Ummm @mchammer01 & @cmwilson21, all of the tests failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try and fix the check failures.
content/get-started/writing-on-github/working-with-advanced-formatting/about-task-lists.md
Outdated
Show resolved
Hide resolved
…rmatting/about-task-lists.md
content/get-started/writing-on-github/working-with-advanced-formatting/about-task-lists.md
Show resolved
Hide resolved
…rmatting/about-task-lists.md
I'll unassign myself for now, until we decide how to proceed with this PR. |
Yup you did. If you're a maintainer, I think you can approve of it. |
@CBID2 👋🏻 - thanks for your note. I haven't reviewed your PR yet because I think, although it looks good, and contains a useful new procedural section, it doesn't answer the part of the issue that mention explaining what conditions must be met to show the hover icon to create issue behind tasklist items. I have ask folks who are more familiar with task lists than me if they can help. |
content/get-started/writing-on-github/working-with-advanced-formatting/about-task-lists.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, @CBID2, thanks so much for picking this up! ✨
It looks like Felicity tested for reasons the icon might not appear in the associated issue and didn't find any.
I made a few little changes via a suggested comment, and included the octicon directly rather than describing it which I think will make this procedural more accessible; the octicon includes the same alt text as the UI, so a screenreader will describe it in the same way.
We've got two unrelated test failures, for our API docs. I'll see if this will merge, if not, I'll ask our engineers to take a look.
Thank you again! ✨
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
This PR adds a section on how to convert tasks created on issues into their own issues. This helps maintainers learn another way to organize their issues.
Closes:
Closes #24862
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.
data
directory.For content changes, I have completed the self-review checklist.