Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain what conditions must be met to show hover icon to create issue behind tasklist items #24862

Closed
1 task done
HonkingGoose opened this issue Apr 4, 2023 · 11 comments · Fixed by #29247
Closed
1 task done
Labels
content This issue or pull request belongs to the Docs Content team get started Content related to "Getting Started" doc set help wanted Anyone is welcome to open a pull request to fix this issue

Comments

@HonkingGoose
Copy link
Contributor

HonkingGoose commented Apr 4, 2023

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/about-task-lists

What part(s) of the article would you like to see updated?

The docs say:

If a task requires further tracking or discussion, you can convert the task to an issue by hovering over the task and clicking button-icon-here in the upper-right corner of the task.

The docs don't explain if there are any rules you need to follow to allow GitHub to show that hover icon, like:

  • only put issue or PR link after the tasklist
  • don't use special characters like ( or )
  • don't do ...

Or maybe this is a "rights" issue where you need a certain level of access to the repository before you see that button?

Additional information

Why I'm asking about any possible rules: @viceice (maintainer of the repository) is not seeing the hover icon behind items in their tasklist:

With the current docs I can't determine if this is:

  • bad formatting of the tasklist
  • a problem with access rights to the repository
  • bug in GitHub

Update from a maintainer

Content change suggested to fix this issue

We need to make it clearer to users how to convert a tasklist item to an issue. We'll do this by adding a brief new section to the article About task lists.

  1. After the section "Reordering tasks", add a new heading level 2 "Converting tasks into issues".
  2. Add a brief explanation of how to convert a task into an issue.
  3. Add the following screenshot to the folder for images about writing: https://github.com/github/docs/tree/main/assets/images/help/writing.
    task-list-convert
  4. Include the image below the explanation and make sure you add suitable alt text (see Images).

You may find it useful to look at the alt text for other images on the page for inspiration, for example:

{% ifversion fpt or ghec %} ![Screenshot of a {% data variables.product.prodname_dotcom %} issue showing two tasks in a task list. A grid of six dots to the left of the second task is outlined in dark orange.](/assets/images/help/writing/task-list-reorder.png){% endif %}

@HonkingGoose HonkingGoose added the content This issue or pull request belongs to the Docs Content team label Apr 4, 2023
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 4, 2023
@cmwilson21
Copy link
Contributor

👋 @HonkingGoose Thanks so much for opening an issue! And thanks for the extra context and providing the example case.

I'll triage this for the team to take a look 👀

@cmwilson21 cmwilson21 added waiting for review Issue/PR is waiting for a writer's review get started Content related to "Getting Started" doc set and removed triage Do not begin working on this issue until triaged by the team labels Apr 4, 2023
@omerbensaadon
Copy link
Contributor

Hey @HonkingGoose, PM here, I would recommend you use the new tasklists as they are meant to replace this version and resolve many of the UX sharp edges you're running into :)

@HonkingGoose
Copy link
Contributor Author

Hi @omerbensaadon, thanks for responding!

New tasklists look nice

Reading the docs for the new tasklists, it looks nice! The waitlist only accepts organization level accounts to try the feature though, so I can't test it on my personal account. I'll have to wait for it to become public before I can try it. 😄

Future enforcement of full links in all body text on GitHub?

I see that tasklists items must use a full link to issues/pull requests. Here's the quote, I bolded the relevant part:

  1. For each item you want to add to your tasklist, type - [ ] on a new line, followed by a space, and either a link to an issue, a link to a pull request, or some text to create a draft issue.
    • You must provide a full link to an issue or pull request. For example, https://github.com/octo-org/octo-repo/issues/45.

I remember GitHub removed the #45 shorthand-syntax a while ago, which was quickly reverted, because the change broke every old link that used the shorhand-syntax. 😄

In the docs I see the new UI has search built in, where you can select the issue you want with the Enter key. I wonder if this change is to prepare for a more general enforcement of using full links? That way GitHub could eventually drop support for the shorthand? Is there anything you can tell me about that @omerbensaadon?

@omerbensaadon
Copy link
Contributor

omerbensaadon commented May 31, 2023

Oh that's not actually true, you can totally use the shorthand or full URLS with new tasklists. Can you link me to where you found that?

@HonkingGoose
Copy link
Contributor Author

@omerbensaadon Here's where I found the text: https://docs.github.com/en/issues/tracking-your-work-with-issues/about-tasklists#creating-tasklists-with-markdown, search for full link. That same page also shows a "finished tasklist" that only uses the full link:

### My tasks
- [ ] https://github.com/octo-org/octo-repo/issues/45
- [ ] Draft issue title

@omerbensaadon
Copy link
Contributor

omerbensaadon commented Jun 6, 2023

Gotcha, I'll submit an edit to that doc which shows a shorthand link to make it clearer we can accept both

@felicitymay
Copy link
Contributor

Hi @HonkingGoose

I was checking through open issues and wondered if this one is now resolved.

I can see that you've worked with another Hubber to improve the documentation for the new tasklists - thank you 💖

Is there anything else we should consider before we close this issue?

@HonkingGoose
Copy link
Contributor Author

@felicitymay the docs for the current iteration of task lists are still lacking information.

But if the plan is that everyone migrates to the new task lists that's in beta, we would need to check those docs.

So the short answer is: I don't really know. 🙂

@felicitymay
Copy link
Contributor

Hi @HonkingGoose - apologies for dropping the ball on this issue 😞

Using a test account that doesn't have access to the private beta for task lists, I copied in some of the text from the issue that you linked in your summary above. As far as I can tell, there is no problem with your syntax and this ought to work as expected for anyone who has access to create issues. The repository owner, @viceice, should have access to this functionality.

image

It sounds as if we should add a brief section to About task lists that includes a screenshot with the "Convert to issue" icon displayed.

@HonkingGoose
Copy link
Contributor Author

It sounds as if we should add a brief section to About task lists that includes a screenshot with the "Convert to issue" icon displayed.

Sounds good to me. 😄

@felicitymay felicitymay added help wanted Anyone is welcome to open a pull request to fix this issue and removed waiting for review Issue/PR is waiting for a writer's review labels Sep 11, 2023
@CBID2
Copy link
Contributor

CBID2 commented Oct 18, 2023

I'll work on this @cmwilson21! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team get started Content related to "Getting Started" doc set help wanted Anyone is welcome to open a pull request to fix this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@felicitymay @omerbensaadon @HonkingGoose @cmwilson21 @CBID2 and others