GITC-632 Have added hardcoded mini-banner for Gitcoin Building Gitcoi… #9766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n. This will be shown instead of an active item CLR item if the name is 'Gitcoin Building Gitcoin'
nutrina
requested review from
chibie,
frankchen07,
gdixon,
PixelantDesign and
thelostone-mc
as code owners
| </a> | ||
| </div> | ||
|
|
||
| {% else %} |
There was a problem hiding this comment.
@nutrina i don't think we'll have an active_round called Gitcoin Building Gitcoin
I'd say just throw it below https://github.com/gitcoinco/web/blob/master/app/grants/templates/grants/landing/active_clr_round.html#L22
There was a problem hiding this comment.
@thelostone-mc Have moved the code as you instructed. But it does not really look good in mobile. Will continue to tweak it a bit ...
There was a problem hiding this comment.
@thelostone-mc Should be final (see the screenshots). It is not perfect, but better than it was.
thelostone-mc
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n. This will be shown instead of an active item CLR item if the name is 'Gitcoin Building Gitcoin'
Description
Have added hardcoded banner for Gitcoin Building Gitcoin
Refers/Fixes
GITC-632
Testing
These are screenshots for my local instance:
