Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GITC-580: implements matching pool filter #9725

Merged
merged 7 commits into from
Nov 29, 2021

Conversation

gdixon
Copy link
Contributor

@gdixon gdixon commented Nov 24, 2021

Description

This PR implements the matching pool filter:

GIVEN a grants round is active
WHEN I am on the Grants Explorer Page
THEN I see a grant round filter, tags, region, blockchain, and "more" filter.

GIVEN a grants round is not active
WHEN I am on the Grants Explorer Page
THEN I do not see a categories filter, only a tags, region, blockchain filter, and a "more" filter.

GIVEN a grants round is active, I'm on the Grants Explorer Page, and see the grant round filter
WHEN I click on the grant round filter
THEN the pill box reads "Grant Round",
AND the arrow carat switches to point up,
AND the primary and secondary menus show:
main (primary) -> all (secondary)
cause (primary) -> (advocacy, longevity, climate change) (secondary)
ecosystem (primary) -> (algorand, uniswap, etc) (secondary) in alphabetical order.

GIVEN I am looking to filter by a primary matching category
WHEN I click on my primary-level selection
THEN the primary item is highlighted
AND the page returns all grants eligible in rounds under the primary matching category selection
AND the pillbox reads "Grant Round: [primary]".

GIVEN I am looking to filter by a secondary matching category
When I click on my secondary-level selection
THEN the secondary item is highlighted with the parent primary item
AND the page returns all grants eligible in rounds under the secondary matching category selection
AND the pillbox reads "Grant Round: [primary] - [secondary]".

GIVEN I have selected options on the grant round filter
WHEN I scroll down on the grant explorer page
THEN the filter bar with the grant round pill will be stickied at the top.

GIVEN I have filtered options using the grant round filter
WHEN I click off the menu
THEN the menu minimizes AND keeps the pillbox selection.

GIVEN I have filtered options using the grant round filter and have clicked away
WHEN I click back into the grant round filter
THEN the menu highlighting and pillbox reflects my previous selection.

GIVEN the design updates on the web platform for the grants explorer matching pool filters
WHEN I view the grant explorer on my mobile
THEN the responsive views will take effect.
Refers/Fixes

Closes: GITC-580

Testing

Screenshot 2021-11-24 at 04 54 59

@gdixon gdixon force-pushed the GITC-580--matching-pool-filter branch from 54aec06 to 0e6ffe1 Compare November 26, 2021 19:44
@thelostone-mc thelostone-mc merged commit eaa9d6c into master Nov 29, 2021
@frankchen07
Copy link
Contributor

frankchen07 commented Nov 29, 2021

  • On staging, it seems like selecting primary or secondary menu items doesn't filter the grants down. I anticipate it showing "0 grants" for most menu selections, but for most of them, it still says 24 grants.

  • Gitcoin Building Gitcoin shows up under "Main" in the filter, but the Main Rounds (All) doesn't show up there.

@gdixon
Copy link
Contributor Author

gdixon commented Nov 29, 2021

On staging, it seems like selecting primary or secondary menu items doesn't filter the grants down. I anticipate it showing "0 grants" for most menu selections, but for most of them, it still says 24 grants.

Gitcoin Building Gitcoin shows up under "Main" in the filter, but the Main Rounds (All) doesn't show up there.

This is because of an error in the CLR configuration:

e.g for Polygon, we need to change:

{"tags": "11", "grant_type": ["1", "2", "6", "7", "8", "10"]}
->

{"tags": "11", "grant_type__in": ["1", "2", "6", "7", "8", "10"]}

@frankchen07
Copy link
Contributor

frankchen07 commented Nov 29, 2021

@gdixon - got it. So I updated the __in, but the primary level filter still doesn't work. You can test it by doing ecosystem rounds?

  • Uniswap filters on uniswap. The other ecosystem specific ones have 0. If I just do all ecosystem as the only primary level, the logic should dictate that it shows the Uniswap ones, right? Right now, nothing happens from all grants.

@frankchen07
Copy link
Contributor

frankchen07 commented Nov 29, 2021

  • Also, it looks like ecosystem rounds aren't showing up on the homepage.

  • And Gitcoin Building Gitcoin is showing up twice.

Screen Shot 2021-11-29 at 3 35 28 PM

@gdixon
Copy link
Contributor Author

gdixon commented Nov 30, 2021

@gdixon - got it. So I updated the __in, but the primary level filter still doesn't work. You can test it by doing ecosystem rounds?

  • Uniswap filters on uniswap. The other ecosystem specific ones have 0. If I just do all ecosystem as the only primary level, the logic should dictate that it shows the Uniswap ones, right? Right now, nothing happens from all grants.

Good catch @frankchen07 - I missed that! I've addressed it here: #9767

@gdixon
Copy link
Contributor Author

gdixon commented Nov 30, 2021

  • Gitcoin Building Gitcoin shows up under "Main" in the filter, but the Main Rounds (All) doesn't show up there.

The round wasn't set to active, its showing up now 👍

@frankchen07
Copy link
Contributor

frankchen07 commented Nov 30, 2021

  • Gitcoin Building Gitcoin round shows in filtering menu (shouldn’t be there at all), is it possible to remove it?

@gdixon
Copy link
Contributor Author

gdixon commented Nov 30, 2021

  • Gitcoin Building Gitcoin round shows in filtering menu (shouldn’t be there at all), is it possible to remove it?

Someone had set the Gitcoin Building Gitcoin round from GR11 to active - fixed now 👍

@gdixon
Copy link
Contributor Author

gdixon commented Nov 30, 2021

  • And Gitcoin Building Gitcoin is showing up twice.

I've raised a PR to correct this: #9768

@gdixon
Copy link
Contributor Author

gdixon commented Nov 30, 2021

  • Also, it looks like ecosystem rounds aren't showing up on the homepage.

I've raised a PR to correct this: #9769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants