feat: side round support + banner tweaks + add tooltip #9641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macotouenaca
approved these changes
Oct 31, 2021
thelostone-mc
force-pushed
the
new_banner
branch
from
ca49c07 to
120dbe8
Compare
thelostone-mc
changed the title
thelostone-mc
requested review from
chibie,
frankchen07,
gdixon and
PixelantDesign
as code owners
gdixon
reviewed
Nov 2, 2021
| height: 111px !important; | ||
| } | ||
|
|
||
| @media (max-width: 991.98px) { |
There was a problem hiding this comment.
Could we add a utility to manage responsive fonts rather than handling them inline?
gdixon
approved these changes
Nov 2, 2021
chibie
suggested changes
Nov 3, 2021
app/grants/models/grant.py
Outdated
Comment on lines
859
to
862
| active_round_names= [] | ||
| for active_round in self.in_active_clrs.all(): | ||
| active_round_names.append(active_round.display_text) | ||
|
|
There was a problem hiding this comment.
great work! just this -> would be more performant if we do
active_round_names = self.in_active_clrs.values_list('display_text', flat=True)
There was a problem hiding this comment.
hmm this won't work as such ! I might have to typcast it into a list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sideround Changes
Updates models to introduce new fields on GrantCLR for mini banner.
While creating a new round , these values would have to be set right in order to ensure it's rendered as expected
type-> select if GrantCLR is main / sponsor / causelogo_text_hex- > hex color of text within logobanner_bg_hex-> hex color of background below logo (aka called banner)banner_text_hex-> hex color of text within bannerbanner_text-> mini text on the bannerGIVEN I am a user on the grants app homepage
WHEN I am looking at the active matching pools
THEN I see a title and description to the entire matching pool section as indicated by the design.
GIVEN I am a user on the grants app homepage
WHEN I am looking at the active matching pools
THEN I see the matching amount above "available", color-coded banners, and matching pool descriptions as indicated by the design.
GIVEN I am a Grants app internal operator on the grant brand routing policy page
WHEN I edit a grant branding policy
THEN I can edit the matching amount, hex color, and description of the matching pool banner.
Testing
Tooltip Changes
As a Grant owner, I want to see how much matching I’ve received from the matching pool(s) my grant are a part of, and understand which matching pools my grant is in.
Acceptance Criteria or Definition of Done
GIVEN I am on a grant detail page
WHEN I look at the metrics under "Active Matching Rounds"
THEN I see the total matching funds the grant has received across all rounds ($X from matching pools).
GIVEN I am looking at the metrics under "Active Matching Rounds"
WHEN I hover over "$X from matching pools"
THEN I see a tooltip with a description explaining what the metric means and which matching pools the grant is a part of.
Testing
Refers/Fixes
closes #9635
closes #9636
closes #9649