-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: side round support + banner tweaks + add tooltip #9641
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c61e3d2
feat: side round support + banner tweaks
thelostone-mc 5c13586
add migration
thelostone-mc eceb759
GITC-562: add matching pools metric and tooltip to grant details
thelostone-mc 120dbe8
update tests
thelostone-mc bc124cd
address feedback
thelostone-mc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
# Generated by Django 2.2.24 on 2021-10-29 09:13 | ||
|
||
from django.db import migrations, models | ||
|
||
|
||
class Migration(migrations.Migration): | ||
|
||
dependencies = [ | ||
('grants', '0126_auto_20211001_0911'), | ||
] | ||
|
||
operations = [ | ||
migrations.AddField( | ||
model_name='grantclr', | ||
name='banner_bg_hex', | ||
field=models.CharField(blank=True, default='#11BC92', help_text='sets the bg color on the banner below the logo', max_length=15, null=True), | ||
), | ||
migrations.AddField( | ||
model_name='grantclr', | ||
name='banner_text', | ||
field=models.CharField(blank=True, help_text='text which appears below banner', max_length=50, null=True), | ||
), | ||
migrations.AddField( | ||
model_name='grantclr', | ||
name='banner_text_hex', | ||
field=models.CharField(blank=True, default='#FFF', help_text='sets the text color on the banner below the logo', max_length=15, null=True), | ||
), | ||
migrations.AddField( | ||
model_name='grantclr', | ||
name='logo_text_hex', | ||
field=models.CharField(blank=True, default='#000000', help_text='sets the text color of the logo', max_length=15, null=True), | ||
), | ||
migrations.AddField( | ||
model_name='grantclr', | ||
name='type', | ||
field=models.CharField(choices=[('main', 'Main Round'), ('sponsor', 'Sponsor Round'), ('cause', 'Cause Round')], default='main', help_text='Grant CLR Type', max_length=25), | ||
), | ||
migrations.AlterField( | ||
model_name='grantclr', | ||
name='customer_name', | ||
field=models.CharField(blank=True, default='', help_text='used to generate customer_name/round_num/sub_round_slug', max_length=15), | ||
), | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
{% if has_active_rounds %} | ||
<div class="container-fluid grants-container"> | ||
<div class="container"> | ||
<div class="mx-0 mb-4 text-center text-md-left"> | ||
<h4 class="font-weight-bold mb-2">Discover Match Pools</h4> | ||
<p class="font-subheader">Match pool categories curated by the Gitcoin Dao and community</p> | ||
</div> | ||
|
||
<div class="row"> | ||
{% if active_main_rounds %} | ||
{% include 'grants/landing/round_by_type.html' with active_rounds=active_main_rounds %} | ||
{% endif %} | ||
|
||
{% if active_cause_rounds %} | ||
{% include 'grants/landing/round_by_type.html' with active_rounds=active_cause_rounds %} | ||
{% endif %} | ||
|
||
{% if active_sponsor_rounds %} | ||
{% include 'grants/landing/round_by_type.html' with active_rounds=active_sponsor_rounds %} | ||
{% endif %} | ||
</div> | ||
|
||
</div> | ||
</div> | ||
{% endif %} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,6 +45,17 @@ | |
align-items: center; | ||
} | ||
|
||
.active-clr-banner { | ||
height: 111px !important; | ||
} | ||
|
||
@media (max-width: 991.98px) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could we add a utility to manage responsive fonts rather than handling them inline? |
||
.active-clr-banner .round-details p { | ||
font-size: 20px; | ||
} | ||
} | ||
|
||
|
||
</style> | ||
<style class="page-styles"> | ||
{% if grant_bg.inline_css %}{{grant_bg.inline_css}}{% endif %} | ||
|
@@ -65,10 +76,10 @@ | |
{% endif %} | ||
|
||
<div id="grants-showcase"> | ||
{% include 'grants/shared/landing_qf_active.html' %} | ||
{% include 'grants/landing/landing_qf_active.html' %} | ||
<div class=""> | ||
<div v-if="isLandingPage" class="my-5"> | ||
{% include 'grants/shared/active_clr_round.html'%} | ||
{% include 'grants/landing/active_clr_round.html'%} | ||
</div> | ||
<div class="mb-5"> | ||
<div class="container"> | ||
|
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
{% load humanize i18n grants_extra %} | ||
{% for active_round in active_rounds %} | ||
<div class="col-12 col-lg-6"> | ||
<a | ||
href="/grants/explorer/?sub_round_slug={{ active_round.sub_round_slug }}&round_num={{ active_round.round_num }}&customer_name={{ active_round.customer_name }}" | ||
class="active-clr-banner d-block text-decoration-none position-relative mt-3" | ||
> | ||
<div class="position-absolute w-100 h-100" style=" | ||
top: 0; | ||
right: 0; | ||
{% if active_round.logo %} | ||
background: url('{{ active_round.logo.url }}') no-repeat center; | ||
{% endif %} | ||
" | ||
> | ||
</div> | ||
<div style="color: {{ active_round.logo_text_hex}}" class="round-details d-flex p-3 justify-content-between position-relative"> | ||
<p class="pr-5 font-bigger-1">{{ active_round.display_text|upper }}</p> | ||
|
||
<div class="text-right"> | ||
<p class="mb-0 font-bigger-2 font-weight-light">${{ active_round.total_pot|humanize_short }}</span> | ||
<p class="mt-0 text-muted font-smaller-1">available</span> | ||
</div> | ||
</div> | ||
</a> | ||
|
||
<div class="font-body d-flex" style="background-color: {{ active_round.banner_bg_hex }}; height: 45px;"> | ||
<p class="px-3 my-auto" style="color: {{active_round.banner_text_hex}} "> | ||
{{ active_round.banner_text }} | ||
</p> | ||
</div> | ||
|
||
</div> | ||
{% endfor %} |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work! just this -> would be more performant if we do
active_round_names = self.in_active_clrs.values_list('display_text', flat=True)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm this won't work as such ! I might have to typcast it into a list