Prevents activity from being deleted by users who don't own that activity #8992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdixon
requested review from
chibie,
frankchen07,
octavioamu,
PixelantDesign,
thelostone-mc and
zlsgh
as code owners
thelostone-mc
pushed a commit
that referenced
this pull request
Jun 7, 2021
…oken with the lowest ID (#8994) * permissions on activity (#8992) Co-authored-by: owocki <[email protected]> * Ensures that all tokens are considered and not just the token with the lowest id Co-authored-by: owocki <[email protected]>
thelostone-mc
pushed a commit
that referenced
this pull request
Jun 8, 2021
* permissions on activity * permissions on activity (#8992) Co-authored-by: owocki <[email protected]> * auto-restore of deadbeat quests Co-authored-by: Graham Dixon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a security vulnerability where by any user can delete activity from any other users profile
Refers/Fixes
refers: email string
Testing
Written by @owocki, verified by @thelostone-mc & myself