Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent quickstart from redirecting to /new page #8594

Merged
merged 2 commits into from
Mar 15, 2021
Merged

prevent quickstart from redirecting to /new page #8594

merged 2 commits into from
Mar 15, 2021

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Mar 15, 2021 •
edited
Loading

@octavioamu
Copy link
Contributor

octavioamu commented Mar 15, 2021 •
edited
Loading

Instead of this changes can we just add btn-closeguide class to the button? is what controls if a modal is present or not on the js logic https://github.com/gitcoinco/web/pull/8381/files#diff-66f8019a317f08929e6e6724999990dcc23295c6beaa3c6bada45274e7b56bcdL68

if (guide && guide.dataset)
              guide.dataset.dismiss = 'modal';

Also need to be changed to

guide.dataset.dismiss = 'modal';
As we want to add data-dismiss=modal to the anchor on the modal (not the close X)

@thelostone-mc thelostone-mc marked this pull request as ready for review March 15, 2021 14:27
@thelostone-mc thelostone-mc merged commit 9e18dd1 into stable Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octavioamu octavioamu octavioamu approved these changes

@chibie chibie Awaiting requested review from chibie

@frankchen07 frankchen07 Awaiting requested review from frankchen07

@gdixon gdixon Awaiting requested review from gdixon

@PixelantDesign PixelantDesign Awaiting requested review from PixelantDesign

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thelostone-mc @octavioamu