prevent quickstart from redirecting to /new page (#8594)

* fix modal reopen in loop * feedback from octo
gitcoinco · Mar 15, 2021 · 9e18dd1 · 9e18dd1
1 parent 49d2bd9
commit 9e18dd1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/app/assets/v2/js/pages/new_bounty.js b/app/assets/v2/js/pages/new_bounty.js
@@ -269,8 +269,7 @@ Vue.mixin({
             doc.querySelector('.show_video').href = 'https://www.youtube.com/watch?v=m1X0bDpVcf4';
             doc.querySelector('.show_video').target = '_blank';
 
-            if (guide && guide.dataset)
-              guide.dataset.dismiss = 'modal';
+            guide.dataset.dismiss = 'modal';
 
             const docArticle = doc.querySelector('.content').innerHTML;
             const content = $.parseHTML(

diff --git a/app/dashboard/templates/quickstart.html b/app/dashboard/templates/quickstart.html
@@ -66,7 +66,7 @@ <h4 class="title text-center">{% trans "Funder Guide" %}</h4>
               </a>
             </div>
             <div class="col-12 text-center">
-              <a href="{% url 'new_funding' %}" class="btn btn-primary btn-lg text-white px-5 py-3">
+              <a href="{% url 'new_funding' %}" class="btn btn-primary btn-lg text-white px-5 py-3 btn-closeguide">
                 {% trans "Ok, I'm ready" %}
               </a>
             </div>