Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts inline .scss block to inline .css block #8553

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

gdixon
Copy link
Contributor

@gdixon gdixon commented Mar 11, 2021

Description

This PR reverts .scss changes made in commit 4763718.

We made these changes because the css being used in shared_template_head.html is duplicated from the core app's css - in order to DRY up the codebase, we wanted to use a single source of truth, unfortunately django-compressor is failing to inline the .scss block in production.

We will readdress this in the future, the path forward will likely be:

  • assess what css is being used by the emails
  • refactor and bring just that css into a single new css document and inline that instead of the 3 .css documents we are currently inlining
  • rename that new document email_head.css so that there is no ambiguity as to what the file is.
Refers/Fixes

Fixes: 4763718

Testing

Tested locally

@octavioamu octavioamu merged commit 8864320 into stable Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants