-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redesign transactional emails #8413
Conversation
…nto chibie/fix-broken-emails
330f098
to
a0f3425
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the video @chibie! Emails are looking great!
One thing I noticed is that we are using our progress indicator in place of the logo. Since the indicator is animated, it might be confusing for users to constantly see the loader refreshing. They may think more information is being refreshed in the email. Is it possible to switch it out for the normal Gitcoin logo?
The other thing I noticed is that the font hierarchy in the transactional emails are different than the design. The fonts and alignment should follow the F pattern established in the hackathon template.
Please check these emails:
- Your Bounty is Now Live
- New mention email
- New comment email
- Faucet processed
- Canceled grant
- You've been removed from a task
- Are you still working on this?
- Your funded bounty is expiring
The last thing is could you include a video of the responsive views?
Otherwise, looking great! Let me know if you have questions @chibie!
- include respective product logo to all email types
screen recording update featuring, responsive design and F patterned alignment + font hierarchy fixes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me!! Good job Chibie!! 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you double check that the changes you've made mean that we don't need those 3 css documents. I checked new_bounty_daily
and we are using the .css to style the activity feed.
sorry I said EOD on Friday but failed. here's my review:
|
Looks good overall! Daily digest looks really good! Is it possible to have all of the templates follow the way the daily digest changes between web and responsive views as well as treatment of headers? On this email |
- center image @featured_funded_bounty
done.
can you explain a bit more? |
Description
workflow checklist:
email checklist:
Refers/Fixes
closes #8218
closes #8355
Testing
https://www.loom.com/share/4681d22aa6d344979290076366598e9d
https://www.loom.com/share/3d66f3f1450a47049ff8d6be9d09958a
nb: observe the hitherto broken emails now work