Adds local static cache for .scss and .js files #8409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdixon
requested review from
chibie,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
chibie
approved these changes
Feb 18, 2021
thelostone-mc
approved these changes
Feb 18, 2021
| # Only save .scss and .js files locally | ||
| if ".scss" in name or ".js" in name: | ||
| # restore the clean file_content | ||
| content.file = file_content |
There was a problem hiding this comment.
why do we do this ? would content.file change after we invoke L60 ?
There was a problem hiding this comment.
We have gzip enabled and from what I can tell, it's applied locally before the file is uploaded. We might not need it, but because we're saving multiple copies, I didn't want to risk losing the content.
octavioamu
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refers/Fixes
Refers: #8368
Testing
Tested in dev with production ENV's