-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New brand styles integration #8368
Conversation
DAMN THIS IS A FANCY PR @gdixon @octavioamu |
<script src="{% static "v2/js/ipfs.js" %}"></script> | ||
<script src="{% static "v2/js/lib/secrets.min.js" %}"></script> | ||
<script src="{% static "v2/js/ethereumjs-accounts.js" %}"></script> | ||
<script src="{% static "onepager/js/send.js" %}"></script> | ||
<script src="{% static "v2/js/truncate-hash.js" %}"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this not needed ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is already loaded on footer_scripts
{% compress css file admin_dashboard %} | ||
<link rel="stylesheet" type="text/x-scss" href={% static "v2/scss/admin/dashboard.scss" %} /> | ||
{% endcompress %} | ||
{% endblock %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-indent with 2 spaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is done, and I've fixed another ~20 templates too!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments but other wise I am excited for this PR
Description
EPIC - New brand styles integration
This PR:
no-descending-specificity
until we've sorted out nesting in the sass files)stylelint --fix
Refers/Fixes
Refers: #8363
Refers: #8308
Refers: #8358