Limit cart to 40 items, regardless of checkout method #8234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mds1
requested review from
amustapha,
chibie,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
thelostone-mc
approved these changes
Jan 13, 2021
|
@mds1 looks like we have lint failures !
could you get those fixed ? |
mds1
force-pushed
the
limit-cart-to-40-items
branch
from
8652402 to
f5a0c6b
Compare
mds1
force-pushed
the
limit-cart-to-40-items
branch
from
f5a0c6b to
2061f45
Compare
|
@thelostone-mc Fixed the lint errors and rebased against master! |
chibie
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8231
In #8145 we only limited zkSync, now we limit standard checkout also.
To test:
maxCartItemsincart.jsto a number like 2. The number set there is the max allowed.