Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit zkSync checkout to 45 items in cart #8145

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Limit zkSync checkout to 45 items in cart #8145

merged 1 commit into from
Dec 17, 2020

Conversation

mds1
Copy link
Contributor

@mds1 mds1 commented Dec 17, 2020 •
edited
Loading

Closes #8114 and #8143

To test:

  1. Either add 45 items to your cart, OR change maxItems in cart-ethereum-zksync.js to a number like 2. The number set there is the max allowed
  2. If you change it to 2, add 2 items to your cart and things should look normal. Add a third and the zkSync button should be disabled with a message

The actual zkSync limit is 50, but we use 45 cart items to leave room for automatic tip contributions which are added as separate transfers

@mds1 mds1 mentioned this pull request Dec 17, 2020
Closed
thelostone-mc
thelostone-mc approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

locally tested ! LGTM

@thelostone-mc thelostone-mc merged commit b2b5983 into gitcoinco:stable Dec 17, 2020
@mds1 mds1 mentioned this pull request Jan 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thelostone-mc thelostone-mc thelostone-mc approved these changes

@amustapha amustapha Awaiting requested review from amustapha

@chibie chibie Awaiting requested review from chibie

@danlipert danlipert Awaiting requested review from danlipert

@frankchen07 frankchen07 Awaiting requested review from frankchen07

@octavioamu octavioamu Awaiting requested review from octavioamu

@PixelantDesign PixelantDesign Awaiting requested review from PixelantDesign

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mds1 @thelostone-mc