feat(binance): integrate BUSD for bounties and hackathons 2 #8213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add util to get token balance - enforce sufficient balance for transfer
… feat/busd-integration
chibie
requested review from
amustapha,
danlipert,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
amustapha
suggested changes
Jan 7, 2021
| @@ -515,6 +515,9 @@ <h5 class="text-uppercase h3 font-weight-bold mb-0">Total</h5> | |||
| <script src="{% static "v2/js/lib/polkadot/extension.min.js" %}"></script> | |||
| <script src="{% static "v2/js/lib/polkadot/utils.js" %}"></script> | |||
|
|
|||
| <script src="https://cdn.jsdelivr.net/npm/@binance-chain/[email protected]/lib/index.min.js"></script> | |||
There was a problem hiding this comment.
This import fails, always.
There was a problem hiding this comment.
should i take it out?
amustapha
approved these changes
Jan 8, 2021
thelostone-mc
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sequel to #8121
fixes some bugs that caused BNB payout to fail.
Testing
bounty creation / start work/ submit work: https://www.loom.com/share/6b95c56baa35477ba17ceee33c497aaa
bounty payout / sync pending fulfillments: https://www.loom.com/share/e37be947f5f44fe7bd55df0198ee3c1e