Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(binance): integrate BUSD for bounties and hackathons #8121

Merged
merged 11 commits into from
Dec 22, 2020

Conversation

chibie
Copy link
Contributor

@chibie chibie commented Dec 15, 2020

Description

This integration is to allow users on the platform use the BUSD token for

  • Bounties
  • Hackathons
Fixes

#8062

Testing

@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #8121 (3398231) into master (5265bdb) will decrease coverage by 7.46%.
The diff coverage is 13.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8121      +/-   ##
==========================================
- Coverage   25.35%   17.89%   -7.47%     
==========================================
  Files         329      320       -9     
  Lines       33401    33946     +545     
  Branches     4997     5067      +70     
==========================================
- Hits         8470     6073    -2397     
- Misses      24641    27859    +3218     
+ Partials      290       14     -276     
Impacted Files Coverage Δ
app/app/settings.py 81.35% <ø> (-0.06%) ⬇️
app/app/urls.py 0.00% <ø> (-86.21%) ⬇️
...d/management/commands/sync_pending_fulfillments.py 0.00% <0.00%> (ø)
app/dashboard/sync/celo.py 14.28% <ø> (ø)
app/dashboard/sync/eth.py 20.00% <0.00%> (-0.64%) ⬇️
app/dashboard/sync/filecoin.py 16.66% <0.00%> (-0.29%) ⬇️
app/dashboard/sync/polkadot.py 21.95% <0.00%> (-0.55%) ⬇️
app/dashboard/sync/zil.py 19.56% <ø> (ø)
app/dashboard/tip_views.py 0.00% <0.00%> (-14.92%) ⬇️
app/economy/tx.py 0.00% <0.00%> (-16.10%) ⬇️
... and 140 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa708bf...a95fa26. Read the comment docs.

- add util to get token balance

- enforce sufficient balance for transfer
@chibie chibie marked this pull request as ready for review December 17, 2020 09:38
@amustapha
Copy link
Contributor

Can you add a video description please.

Copy link
Contributor

@octavioamu octavioamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!!

@octavioamu
Copy link
Contributor

octavioamu commented Dec 18, 2020

@chibie be sure to update your branch with master and check travis failing before merging it.
As a general rule as now travis is back again we merge branchs when travis is green unless the error is not from your code (like now)

@thelostone-mc
Copy link
Member

@aamustapha / @chibie could you tell me what to add to the Token Table
Decimals + token symbol + chain id etc etc
I'll add it in

@thelostone-mc thelostone-mc merged commit 78d5ba7 into master Dec 22, 2020
@amustapha
Copy link
Contributor

Chain_id is 56

Token symbol
BNB and BUSD.

Conversion

  • 1 BNB -> 29 USDT (as at last I worked on it)
  • 1 BUSD -> 1 USDT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants