Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix css distortion in grants sidebar #7705

Merged
merged 4 commits into from
Oct 28, 2020
Merged

fix css distortion in grants sidebar #7705

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8e34478
fix css distortion in grants sidebar
chibie Oct 19, 2020
b0a149d
adjust style for only affected div
chibie Oct 21, 2020
162a2ed
Merge branch 'master' into fix-dropdown-button-overlap
danlipert Oct 27, 2020
261ce3e
Merge branch 'master' into fix-dropdown-button-overlap
danlipert Oct 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/assets/v2/css/sidebar_search.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
.sidebar_search {
padding: 20px 20px 10px 40px;
width: 100%;
}

.subheading {
Expand Down Expand Up @@ -106,6 +107,7 @@
margin-left: 10px;
margin-right: 10px;
padding: 20px 20px 10px;
width: 100%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is shared on tribes and other part of the site I think should be better instead just use w-100 class on the html to be safe is not going to break nothing on the other pages

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is probably a good idea @chibie - we often find when we change css thats used on multiple pages some visual errors someplace else weeks later... 😆

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh right! i'll fix this in a bit

Copy link
Contributor Author

@chibie chibie Oct 21, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@octavioamu @danlipert done!

}
}

Expand Down
2 changes: 1 addition & 1 deletion app/grants/templates/grants/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
{% endif %}
<div id="grants-showcase" v-cloak>
<div class="row" style="max-width: 99vw">
<div class="col-12 col-lg-3 col-xl-2 pr-xl-0" id="sidebar_container">
<div class="col-12 col-lg-3 col-xl-2 pr-0" id="sidebar_container">
{% include 'grants/shared/sidebar_search.html' %}
</div>

Expand Down