-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix css distortion in grants sidebar #7705
fix css distortion in grants sidebar #7705
Conversation
@aamustapha the sidebar_search currently uses up the full width of col-3 for 3-9 column set "$50k - Space Race 2 (Filecoin)" a max length of 20 characters works well. as shown in this sample using 9999 superscript for matic |
Well, in this case I'd recommend either, increasing the width of the sidebar a little or, reducing the size of the font a little. I just feel it'd be neat if we're able to wrap everything on one line. You could also decide to go rogue and use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment just for caution
app/assets/v2/css/sidebar_search.css
Outdated
@@ -106,6 +107,7 @@ | |||
margin-left: 10px; | |||
margin-right: 10px; | |||
padding: 20px 20px 10px; | |||
width: 100%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file is shared on tribes and other part of the site I think should be better instead just use w-100 class on the html to be safe is not going to break nothing on the other pages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is probably a good idea @chibie - we often find when we change css thats used on multiple pages some visual errors someplace else weeks later... 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh right! i'll fix this in a bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@octavioamu @danlipert done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see Octavio's comment
Codecov Report
@@ Coverage Diff @@
## master #7705 +/- ##
==========================================
+ Coverage 25.42% 25.44% +0.01%
==========================================
Files 328 328
Lines 33044 33044
Branches 4918 4919 +1
==========================================
+ Hits 8401 8407 +6
+ Misses 24356 24350 -6
Partials 287 287
Continue to review full report at Codecov.
|
Description
Fix distortion in grants sidebar categories
before:
after:
Fixes
Fixes #7391