Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix css distortion in grants sidebar #7705

Merged
merged 4 commits into from
Oct 28, 2020

Conversation

chibie
Copy link
Contributor

@chibie chibie commented Oct 19, 2020

Description

Fix distortion in grants sidebar categories

before:

image

after:

image

Fixes

Fixes #7391

@amustapha
Copy link
Contributor

This still falls on 2 lines.
image20

I think a good fix might have to make the root view flex and setting a minimum width on the sidebar_search.

@chibie
Copy link
Contributor Author

chibie commented Oct 20, 2020

@aamustapha

the sidebar_search currently uses up the full width of col-3 for 3-9 column set

"$50k - Space Race 2 (Filecoin)"
is too long for a category name and truncating wouldn't be nice. there should be a max character length for category name considering there's also a superscript

a max length of 20 characters works well. as shown in this sample using 9999 superscript for matic

image

@amustapha
Copy link
Contributor

Well, in this case I'd recommend either, increasing the width of the sidebar a little or, reducing the size of the font a little. I just feel it'd be neat if we're able to wrap everything on one line.

You could also decide to go rogue and use overflow: visible 🤡

@chibie
Copy link
Contributor Author

chibie commented Oct 20, 2020

i guess the filecoin category has been renamed

image

Copy link
Contributor

@aamustapha-gitcoin aamustapha-gitcoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@octavioamu octavioamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment just for caution

@@ -106,6 +107,7 @@
margin-left: 10px;
margin-right: 10px;
padding: 20px 20px 10px;
width: 100%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is shared on tribes and other part of the site I think should be better instead just use w-100 class on the html to be safe is not going to break nothing on the other pages

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is probably a good idea @chibie - we often find when we change css thats used on multiple pages some visual errors someplace else weeks later... 😆

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh right! i'll fix this in a bit

Copy link
Contributor Author

@chibie chibie Oct 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@danlipert danlipert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see Octavio's comment

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #7705 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7705      +/-   ##
==========================================
+ Coverage   25.42%   25.44%   +0.01%     
==========================================
  Files         328      328              
  Lines       33044    33044              
  Branches     4918     4919       +1     
==========================================
+ Hits         8401     8407       +6     
+ Misses      24356    24350       -6     
  Partials      287      287              
Impacted Files Coverage Δ
app/marketing/mails.py 11.88% <0.00%> (-0.03%) ⬇️
app/retail/emails.py 20.43% <0.00%> (ø)
app/dashboard/models.py 50.01% <0.00%> (+0.04%) ⬆️
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faee476...261ce3e. Read the comment docs.

@danlipert danlipert merged commit 974d95c into gitcoinco:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown arrows in categories section overlap to next line
5 participants