Generate collection thumbnail #7587

zoek1 · 2020-10-02T06:26:51Z

Description

https://www.loom.com/share/df2bc6a33c38487d956e05a9eb552353

Refers/Fixes

Testing

thelostone-mc · 2020-10-04T11:29:39Z

app/grants/views.py

+
+
+@login_required
+@staff_member_required


^ why does need a login + staff decorator?

This Is for development and debug purposes like the email views.

thelostone-mc · 2020-10-09T11:08:04Z

@zoek1 could you fix up the conflicts as well

zoek1 · 2020-10-12T05:51:35Z

conflicts fixed @thelostone-mc

thelostone-mc · 2020-10-12T12:27:17Z

app/grants/views.py

+def collection_thumbnail(request, collection_id):
+    width = int(request.GET.get('w', 600))
+    height = int(request.GET.get('h', 400))
+    collection = GrantCollection.objects.get(pk=collection_id)


^ try + catch ?

IMHO since this method is for development purposes is better to show the exceptions instead of caching them.

octavioamu

looking good just left a comment about a default user avatar

octavioamu · 2020-10-12T15:09:46Z

app/grants/templates/grants/components/collection.html

@@ -33,9 +33,10 @@
              <img :src="getGrantLogo(3)" alt="" v-if="collection.grants.length >= 4">
            </div>
          </div>
-          <div class="collection-item__owner-image--cover">
+          <div class="collection-item__owner-image--cover" v-if="!collection.cover">
            <img :src="collection.owner.avatar_url || 'https://c.gitcoin.co/avatars/57e79c0ae763bb27095f6b265a1a8bf3/thelostone-mc.svg'">


wait this is from the old code but if not user is default to thelostone avatar? users always have an avatar_url, if not the fallback should be github one, the same way we do in other places

PixelantDesign

Could we make the dark border thinner and put a circle behind the avatar, and make it 30% larger?

See example here

zoek1 · 2020-11-11T07:57:44Z

what do you think @PixelantDesign?

codecov · 2020-11-13T02:34:02Z

Codecov Report

Merging #7587 (b9a7936) into grants-round-8 (c4774e0) will increase coverage by 0.01%.
The diff coverage is 17.24%.

@@                Coverage Diff                 @@
##           grants-round-8    #7587      +/-   ##
==================================================
+ Coverage           25.34%   25.36%   +0.01%     
==================================================
  Files                 331      330       -1     
  Lines               33800    33456     -344     
  Branches             5047     4993      -54     
==================================================
- Hits                 8567     8486      -81     
+ Misses              24946    24685     -261     
+ Partials              287      285       -2

Impacted Files	Coverage Δ
...management/commands/build_collection_thumbnails.py	`0.00% <0.00%> (ø)`
app/grants/urls.py	`100.00% <ø> (ø)`
app/grants/utils.py	`19.07% <11.53%> (-4.16%)`	⬇️
app/grants/models.py	`39.36% <26.66%> (-1.32%)`	⬇️
app/grants/views.py	`10.93% <38.46%> (+0.60%)`	⬆️
app/grants/tasks.py	`15.54% <0.00%> (-1.88%)`	⬇️
app/grants/admin.py	`44.63% <0.00%> (-0.71%)`	⬇️
app/dashboard/admin.py	`61.66% <0.00%> (-0.28%)`	⬇️
app/app/settings.py	`81.40% <0.00%> (-0.10%)`	⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4774e0...e4d7ec8. Read the comment docs.

* setup json grants endpoint and view * add remove from cart * add model fields * add styles * template changes * links on cat * grant edition * Kevin fix multigrant (#7870) * n:n matching rounds <> grants * add migration * chore: tiny fixes Co-authored-by: owocki <[email protected]> * fix(grant): validate twitter handle for /grants/new (#7890) * fix(grant): validate twitter handle for /grants/new * fix(grants): validate twitter handle in /new * fix broken grant creation + add region support * Idena Integration (#7646) * Added basic setups * Implemented rest of flow * Import refactoring * Compress new image * Removed Idena from soon section * Typo * Redesign idena trust section * Check for idena uniques * Applied review suggestion * Added idena disconnect button * Moved idena_token from database to redis * Moved idena_nonce from database to redis * Moved idena_status and is_idena_verified to db from redis * Added update_idena_status command * Added recheck button * Added daily cronjob for update idena status * Added idena to post data * Added idena to clr calculation * Added idena to trust bounes * Typo * Some tweaks * Recreated migration Co-authored-by: Aditya Anand M C <[email protected]> * recreate migration * Add Saturation Documentation (#7887) * add quick documentation on saturation methods. * add saturation documentation migration Co-authored-by: Aditya Anand M C <[email protected]> * set default prediction curve * another fix * save grant * saving grant is killing me * was a comma... * fix quill render * add editable fields * video in description * refactor of grantclr to make the round_num an actual int + add a subround/customer field (#7685) * WIP refactor * linter * adds customer field * fix: help texts in model fields * fix(views): sub_round_slug default should be 'all' * attempt at frontend todos * feat: make customer_name & sub_round_slug optional - add unique_together constraint * feat: more params to clr_grants view and /clr urls * feat: implement new clr params in frontend * feat: new migration * feat: add new clr params in card info * update pledge grant creation * merge migrations Co-authored-by: Chibuotu Amadi <[email protected]> * add new endpoint for grant cancellation (#7912) * cancel grant * zkSync refactor (#7899) * Initial setup and cleanup for zksync refactor * zkSync CheckoutManager now implemented and working * Handle unsupported tokens and update fee estimate accordingly * Support fee estimation, delete old zksync code, pass data to parent with events * Add zkSync modal with all required functionality * Add zksync balance check, warn user if closing window after checkout started * Bump zksync version * Add missing grant_type field to default Rinkeby grants, update zksync gas estimate (#7915) * fix for grants without type * Add ActiveCLR Navigations (#7877) * Add custom display text and owner to model * Include active_clr rounds in context data * Update the sidebar with active_clr links * Add active CLRs on grants top * Fix spacing * Make banner clickable * Fix sidebar activerounds link * Reorder sidebar * Fix indent * Redo migrations * Use gitcoin icon as default * Fix indent * Hide sidenav if no active CLR rounds * fix: use sub_round_slug in active_clr_round display * new migration * use sub_round_slug in sidebar_search * indent code * chore: update help text * fix issue * update help text * improve display of clr round text Co-authored-by: Chibuotu Amadi <[email protected]> Co-authored-by: Aditya Anand M C <[email protected]> * chore(grants): estimate clr via celery (#7913) * chore: move predict_clr to celery task * keep predict_clr login in clr.py; house keeping * update clr print statements with sub_round_slug * add debug comment to predict_clr task * move print statements to predict_clr celery; use passed args * review feedback * add missing 'self' argument to predict_clr task Co-authored-by: Aditya Anand M C <[email protected]> * ui: redo collection UI #7750 (#7929) * Make Grant Banner/Bacgkround image customizable (#7855) * Fix reverse url issue by checking if params exist * Fix typo * Create model and register in Admin * Display custom routing policy * Add comment to model class and fix display in admin * Fix incorrect variable spelling * Redo Migrations * Create new model and add further model docs * Removed trailing comma * recreate migration Co-authored-by: Aditya Anand M C <[email protected]> * fix styles and model repr * Implement new contributions flow (#7891) * Implement new flow * backend wiring * update banner button styling * minor fix Co-authored-by: Aditya Anand M C <[email protected]> * Check if query params exists before attempting to access elements / Grants auto fill (#7898) * Check if query params exists before attempting to access elements * Uncomment block * Rewrite to use URLSearchParams * add image upload to details edit * fix code * bump eslint optional-chaining support and fix lint errors * remove prints * Refactor And Improve The Trust Bonus Tab (#7934) * Replace the Ad-hoc Trust Bonus UI with a single Vue App * Remove the trust bonus template and replace it with a new one that uses Vue top to bottom * Create a re-usable Vue component for active trust service rows, with events for callbacks, and slots for overriding any given component of the UI as needed * Create individual Vue components for each of the modal views required by certain trust services, including refactoring the BrightID implementation to use Vue * Cleanup copy and design of the POAP modal * Convert the new Idena row to use the Vue component * Rip all SMS verification code out of the cart * Show Trust Bonus message in cart based on all services * Send a single email for all grant items in cart (#7880) * Send a single email for all items in cart Don't send an email for negative grant contribution as well as wait for grant processing task to complete before sending Remove old code Remove space Remove unused import Update with new templates Co-authored-by: Miguel Angel Gordián <[email protected]> * Ensure styles are the same * Remove chord * Update thank_you_for_supporting.txt * Fix sync helper to use new api Co-authored-by: Miguel Angel Gordián <[email protected]> * bump travis node version * Generate collection thumbnail (#7587) * Genrate collection thumbnail * Fix tuple error on grant url * Update avatar for collection thumbs * #7822 * travis npm cache false * travis syntax * compress image and upload logo * add "maximize your grant" blog link to new grant email (#7945) * Grants checkout POST request + tx validator updates (#7942) * Some cleanup/prep before updating POST requests * Saves and deletes JSON store for standard checkout * Working POST requests with validation for L1 and L2 checkout * Various validator changes and setup + upgrade zksync-checkout version + enforce from address * Add migration for updating checkout_type field * Add checkout_type support, fix beforeunload handler, bump zksync-checkout version * Set checkout_type on contribution creation * Remove unused grant checks and unused zksync-recovery code * Validator properly validates zkSync transactions * a/b test of sort order (#7941) * #7792 * redo mig + fix indent Co-authored-by: Aditya Anand M C <[email protected]> * add twitter verification * missing migration * quick view * fix styles and bugs * Fixing idena verified badge (#7946) * fix broken UI * show my items only if user is logged in * update text in did you know * update helptext + make background_image in GRPolicy * add policy name in GRPolicy * update grant cancel text * split button into 2 lines * round off decimals * remove current/past sponsors * fix broke CLR URL in UI * ensure rectangular CLR banner gets applied on landing * fix banner image + append / to url * clear error on successfull submit * hide prediction curve when grant is not part of CLR * title styles * fix UI error * enable tabs * styles for tx tab * show only active grant types in UI * back link * fix rerender rich description * Fix incorrect donation summary values (#7952) * make label clickable * add idle grants * validation * fix edit grants bug * add browser validation * strict validation * hide follow on logout * fix checker for landing * post_data fix for grants round 8 * update grant count * broken addToCart URL * fix grant edit flow * chore: show view collection instead on add to cart in explorer * ensure logged in user sees fav + add to collection * fix broken code * Fix display of some collections (#7960) * revert: multiple contrib -> 1 email change * Fixes grants 8 (#7962) * Fix checkIsCurator function * Fix removeCollection function due to bad object construction * Remove mandatory @ and validate twitter urls * add is on team for cart * change card state from sidebar * small clr styles * fix(grants): backend twitter validation (#7961) * revert: multiple contrib -> 1 email change * fix: twitter validation * validate twitter handle in grant edit * add missing '@' symbol * fix if logic * improve backend validation * fix spacing * fix indentation * return response; save username in db Co-authored-by: Aditya Anand M C <[email protected]> * add back sidecart to details * add compressor to grants creation * Bump zksync version, prevent user from clicking standard checkout button twice (#7972) * Open Idena download link in a new tab (#7973) * Fix twitter profile verification error (#7974) * fix thumbail and grant preview on mini collections view (#7975) * unify styles * fix broken ts * fix twitter username validation in frontend (#7976) * fix edit grants not working (#7977) * remove logo watcher * collections card images css * Email & other fixes (#7964) * quest_of_the_day return 0 if length is 0 * Returns an IndexError otherwise * fix: remove <br/> * the buttons need to be placed sideways * Minor ui fix * Replace Slack icon to Discord invite in emails' footer * update gr8 twitter cards (#7980) * eslint Co-authored-by: Aditya Anand M C <[email protected]> Co-authored-by: owocki <[email protected]> Co-authored-by: Chibuotu Amadi <[email protected]> Co-authored-by: Rhonin <[email protected]> Co-authored-by: fronk <[email protected]> Co-authored-by: Matt <[email protected]> Co-authored-by: Abdulhakeem Adetunji Mustapha <[email protected]> Co-authored-by: Miguel Angel Gordián <[email protected]> Co-authored-by: Ben DiFrancesco <[email protected]> Co-authored-by: corydickson <[email protected]> Co-authored-by: Angela Gilhotra <[email protected]> Co-authored-by: Dan Lipert <[email protected]>

Genrate collection thumbnail

b24be3f

zoek1 requested review from danlipert, frankchen07, octavioamu, PixelantDesign and thelostone-mc as code owners October 2, 2020 06:26

zoek1 added 2 commits October 2, 2020 02:37

Fix tuple error on grant url

2318eda

Merge branch 'master' into feat/collection-thumb

77eb00f

thelostone-mc reviewed Oct 4, 2020

View reviewed changes

Merge branch 'master' into feat/collection-thumb

a81595e

zoek1 requested a review from thelostone-mc October 12, 2020 05:51

thelostone-mc reviewed Oct 12, 2020

View reviewed changes

octavioamu suggested changes Oct 12, 2020

View reviewed changes

PixelantDesign suggested changes Oct 13, 2020

View reviewed changes

danlipert marked this pull request as draft November 4, 2020 12:31

Merge master and fix conflicts

72506d1

zoek1 added 2 commits November 11, 2020 02:01

Update avatar for collection thumbs

aec3a31

Fix conflicts

65263e2

zoek1 marked this pull request as ready for review November 11, 2020 08:07

zoek1 requested review from amustapha and chibie as code owners November 11, 2020 08:07

zoek1 requested review from octavioamu and thelostone-mc November 11, 2020 08:07

Merge branch 'master' into feat/collection-thumb

b9a7936

thelostone-mc changed the base branch from master to grants-round-8 November 19, 2020 12:55

chibie approved these changes Nov 25, 2020

View reviewed changes

zoek1 added 2 commits November 25, 2020 02:40

Fix merge conflict on grants-round-8

e94e41c

fix import conflict

e4d7ec8

thelostone-mc merged commit 5c51d8f into gitcoinco:grants-round-8 Nov 25, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generate collection thumbnail #7587

Generate collection thumbnail #7587

zoek1 commented Oct 2, 2020

thelostone-mc Oct 4, 2020

zoek1 Oct 6, 2020

thelostone-mc commented Oct 9, 2020

zoek1 commented Oct 12, 2020

thelostone-mc Oct 12, 2020

zoek1 Nov 11, 2020

octavioamu left a comment

octavioamu Oct 12, 2020

PixelantDesign left a comment

zoek1 commented Nov 11, 2020

codecov bot commented Nov 13, 2020 •

edited

Loading



		@login_required
		@staff_member_required

Generate collection thumbnail #7587

Generate collection thumbnail #7587

Conversation

zoek1 commented Oct 2, 2020

Description

Refers/Fixes

Testing

thelostone-mc Oct 4, 2020

Choose a reason for hiding this comment

zoek1 Oct 6, 2020

Choose a reason for hiding this comment

thelostone-mc commented Oct 9, 2020

zoek1 commented Oct 12, 2020

thelostone-mc Oct 12, 2020

Choose a reason for hiding this comment

zoek1 Nov 11, 2020

Choose a reason for hiding this comment

octavioamu left a comment

Choose a reason for hiding this comment

octavioamu Oct 12, 2020

Choose a reason for hiding this comment

PixelantDesign left a comment

Choose a reason for hiding this comment

zoek1 commented Nov 11, 2020

codecov bot commented Nov 13, 2020 • edited Loading

Codecov Report

codecov bot commented Nov 13, 2020 •

edited

Loading