Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grants round 8 #7900

Merged
merged 122 commits into from
Dec 1, 2020
Merged

Grants round 8 #7900

merged 122 commits into from
Dec 1, 2020

Conversation

octavioamu
Copy link
Contributor

@octavioamu octavioamu commented Nov 18, 2020

Description

Integration branch for grants round 8
https://github.com/gitcoinco/web/projects/52

Refers/Fixes
Testing

chibie and others added 11 commits November 19, 2020 00:00
* fix(grant): validate twitter handle for /grants/new

* fix(grants): validate twitter handle in /new
* Added basic setups

* Implemented rest of flow

* Import refactoring

* Compress new image

* Removed Idena from soon section

* Typo

* Redesign idena trust section

* Check for idena uniques

* Applied review suggestion

* Added idena disconnect button

* Moved idena_token from database to redis

* Moved idena_nonce from database to redis

* Moved idena_status and is_idena_verified to db from redis

* Added update_idena_status command

* Added recheck button

* Added daily cronjob for update idena status

* Added idena to post data

* Added idena to clr calculation

* Added idena to trust bounes

* Typo

* Some tweaks

* Recreated migration

Co-authored-by: Aditya Anand M C <[email protected]>
* add quick documentation on saturation methods.

* add saturation documentation migration

Co-authored-by: Aditya Anand M C <[email protected]>
@@ -98,7 +98,7 @@ <h2 class="grant-item__title font-subheader">
</span>
</div>
</div>
<template v-if="cred.is_authenticated">
<template v-if="isUserLogged">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thelostone-mc this will not work this componet doesn't have isUserLogged (this only exist on grant details component) the prop for this component is named cred

Copy link
Member

@thelostone-mc thelostone-mc Nov 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There wasn't a prop called cred causing this check to fail!
I did see credentials but I wasn't able to access that as well

isUserLogged -> seemed to work fine on the landing page as well

zoek1 and others added 20 commits November 30, 2020 16:04
* Fix checkIsCurator function

* Fix removeCollection function due to bad object construction

* Remove mandatory @ and validate twitter urls
* revert: multiple contrib -> 1 email change

* fix: twitter validation

* validate twitter handle in grant edit
* add missing '@' symbol

* fix if logic

* improve backend validation

* fix spacing

* fix indentation

* return response; save username in db

Co-authored-by: Aditya Anand M C <[email protected]>
* quest_of_the_day return 0 if length is 0
  * Returns an IndexError otherwise

* fix: remove <br/>
  * the buttons need to be placed sideways

* Minor ui fix

* Replace Slack icon to Discord invite in emails' footer
@octavioamu octavioamu marked this pull request as ready for review December 1, 2020 14:32
@thelostone-mc thelostone-mc merged commit fefe021 into master Dec 1, 2020
@@ -49,24 +49,11 @@ def handle(self, *args, **options):

if active_clr_rounds:
for clr_round in active_clr_rounds:
print(f"CALCULATING CLR estimates for ROUND: {clr_round.round_num}")
predict_clr(
process_predict_clr(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw; this doesnt actually delegate the tasks to the queues. it just runs it inline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.