Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up TS #7062

Merged
merged 1 commit into from
Jul 6, 2020
Merged

chore: clean up TS #7062

merged 1 commit into from
Jul 6, 2020

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Jul 5, 2020

Description

  • fix up alignment on tooltip
  • fix up clunky UI + made stuff more breathable
  • added in some dark mode fixes
  • removed weird accordion and reused existing code
  • reindent TS files

Built on top of 7f2311f
(pushed this into master as it had small fixes)

Testing

https://share.vidyard.com/watch/TPCDPvfToxBH45eJYaBZfd?

@codecov
Copy link

codecov bot commented Jul 5, 2020

Codecov Report

Merging #7062 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7062      +/-   ##
==========================================
+ Coverage   26.29%   26.31%   +0.02%     
==========================================
  Files         301      301              
  Lines       29224    29224              
  Branches     4293     4293              
==========================================
+ Hits         7685     7691       +6     
+ Misses      21268    21262       -6     
  Partials      271      271              
Impacted Files Coverage Δ
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f2311f...8e06e94. Read the comment docs.

@danlipert danlipert merged commit 4bf0d1b into gitcoinco:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants