Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dark mode and fixed links #7047

Closed
wants to merge 1 commit into from

Conversation

developerfred
Copy link
Contributor

@developerfred developerfred commented Jul 2, 2020

Description

I added dark mode and new features to sign up for the hackathon

Refers/Fixes

#6870 #7030

Testing

Screen Shot 2020-07-02 at 19 47 45

@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #7047 into master will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7047      +/-   ##
==========================================
+ Coverage   26.28%   26.30%   +0.01%     
==========================================
  Files         300      300              
  Lines       29359    29372      +13     
  Branches     4321     4325       +4     
==========================================
+ Hits         7718     7725       +7     
- Misses      21365    21376      +11     
+ Partials      276      271       -5     
Impacted Files Coverage Δ
app/townsquare/views.py 9.27% <0.00%> (-0.23%) ⬇️
app/quests/views.py 16.22% <0.00%> (ø)
app/dashboard/views.py 10.57% <0.00%> (ø)
...rketing/management/commands/no_applicants_email.py 0.00% <0.00%> (ø)
...eting/management/commands/assemble_leaderboards.py 39.73% <0.00%> (ø)
app/marketing/mails.py 11.00% <0.00%> (+0.07%) ⬆️
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b5e485...868553a. Read the comment docs.

@octavioamu
Copy link
Contributor

@willsputra so the solution Fred made here is inverted the logo colors but is not good for brandings should we frame the logo into white background?
Fred also check the card to use first the svg logo if not then fallback to png

@willsputra
Copy link
Contributor

@octavioamu yea inverting the logo might not work. sponsors will complain if their logo changed colors 😂

fixed background color will be problematic too tho (what if their logo is white). could we use the same backgrounds as https://gitcoin.co/hackathon-list ?

@developerfred
Copy link
Contributor Author

developerfred commented Jul 3, 2020

Yes @willsputra! @octavioamu I will change this.

0c35f30

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments

@thelostone-mc
Copy link
Member

@developerfred looks like indentation has changed
All html+ js + css -> 1 tab = 2 spaces
Could you undo these + re-ident the new html file with 2 spaces

@thelostone-mc
Copy link
Member

@developerfred Making this into draft for now ! Once those changes have been addressed -> switch it to ready and we can get it in

@thelostone-mc thelostone-mc marked this pull request as draft July 14, 2020 05:38
@developerfred developerfred marked this pull request as ready for review July 14, 2020 17:30
@developerfred
Copy link
Contributor Author

@thelostone-mc done, I'll add the upcoming feature in another pull request

@thelostone-mc thelostone-mc marked this pull request as draft July 20, 2020 10:23
Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@developerfred We can't get this PR in until all the comments have been addressed!
Feel free to add in new changes if you'd want but we can get PRs only after the feedback is addressed

@developerfred
Copy link
Contributor Author

@thelostone-mc ah ok! I ended up sending to the same branch the upcoming I will remove and add in a new one.

@developerfred
Copy link
Contributor Author

@developerfred We can't get this PR in until all the comments have been addressed!
Feel free to add in new changes if you'd want but we can get PRs only after the feedback is addressed

done [x]

@thelostone-mc
Copy link
Member

Hey @developerfred we're closing this out for now cause we go the fixes in ! thanks though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants