-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: dark mode and fixed links #7047
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7047 +/- ##
==========================================
+ Coverage 26.28% 26.30% +0.01%
==========================================
Files 300 300
Lines 29359 29372 +13
Branches 4321 4325 +4
==========================================
+ Hits 7718 7725 +7
- Misses 21365 21376 +11
+ Partials 276 271 -5
Continue to review full report at Codecov.
|
@willsputra so the solution Fred made here is inverted the logo colors but is not good for brandings should we frame the logo into white background? |
@octavioamu yea inverting the logo might not work. sponsors will complain if their logo changed colors 😂 fixed background color will be problematic too tho (what if their logo is white). could we use the same backgrounds as https://gitcoin.co/hackathon-list ? |
Yes @willsputra! @octavioamu I will change this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few comments
69e931e
to
af8fdf7
Compare
@developerfred looks like indentation has changed |
177d335
to
aff07e8
Compare
@developerfred Making this into draft for now ! Once those changes have been addressed -> switch it to ready and we can get it in |
1d09f37
to
c2402af
Compare
c2402af
to
868553a
Compare
@thelostone-mc done, I'll add the upcoming feature in another pull request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@developerfred We can't get this PR in until all the comments have been addressed!
Feel free to add in new changes if you'd want but we can get PRs only after the feedback is addressed
@thelostone-mc ah ok! I ended up sending to the same branch the upcoming I will remove and add in a new one. |
6c311f3
to
868553a
Compare
done [x] |
Hey @developerfred we're closing this out for now cause we go the fixes in ! thanks though |
Description
I added dark mode and new features to sign up for the hackathon
Refers/Fixes
#6870 #7030
Testing