Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop Over Over Site #6771

Merged
merged 7 commits into from
Jun 17, 2020
Merged

Pop Over Over Site #6771

merged 7 commits into from
Jun 17, 2020

Conversation

molecula451
Copy link
Contributor

@molecula451 molecula451 commented Jun 4, 2020

Description

Untitled

Screenshot from 2020-06-05 08-18-08

  • About Page
  • Search Results
  • Leaderboard Rank
Refers/Fixes
Testing

@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #6771 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6771      +/-   ##
==========================================
+ Coverage   26.65%   26.67%   +0.02%     
==========================================
  Files         294      294              
  Lines       28134    28134              
  Branches     4139     4139              
==========================================
+ Hits         7498     7504       +6     
+ Misses      20370    20364       -6     
  Partials      266      266              
Impacted Files Coverage Δ
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90a69a8...0d3af54. Read the comment docs.

@molecula451 molecula451 changed the title Pop Over Pop Over Over Site Jun 6, 2020
@molecula451 molecula451 marked this pull request as ready for review June 6, 2020 03:14
@frankchen07
Copy link
Contributor

is there a ticket for what the supposed changes were supposed to be? or is it just adding profile popups for three locations?

  1. about page
  2. search results
  3. leaderboard rank

@molecula451
Copy link
Contributor Author

Hey there @frankchen07 check #6610 I've working to add the pop over almost where every profile is shown. You can also track the whole addition in PR 6660 & PR 6617

Copy link
Contributor

@PixelantDesign PixelantDesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you able to post a video of this?
If a user hasn't sent any tips or has no data to display in a particular section of the card. Could we hide that information?

What do you think @octavioamu?

@molecula451
Copy link
Contributor Author

Are you able to post a video of this?
Hi! @PixelantDesign preview

If a user hasn't sent any tips or has no data to display in a particular section of the card. Could we hide that information?

Bounty scope is to pop over card when every profile is shown

What do you think @octavioamu?

@PixelantDesign
Copy link
Contributor

Thanks for the video @molecula451.

@thelostone-mc thelostone-mc merged commit 6d898ef into gitcoinco:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants