Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop Over Across the site #6617

Merged
merged 6 commits into from
May 13, 2020
Merged

Pop Over Across the site #6617

merged 6 commits into from
May 13, 2020

Conversation

molecula451
Copy link
Contributor

@molecula451 molecula451 commented May 7, 2020

Description

record-03045607052020

handlergrant

popover activity feed

popoverover

Refers/Fixes

Fixes #6610

Testing

Hacking Completed......

@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #6617 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6617      +/-   ##
==========================================
+ Coverage   27.12%   27.14%   +0.02%     
==========================================
  Files         290      290              
  Lines       26940    26940              
  Branches     3972     3972              
==========================================
+ Hits         7308     7314       +6     
+ Misses      19364    19358       -6     
  Partials      268      268              
Impacted Files Coverage Δ
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed449bb...9af06b4. Read the comment docs.

@molecula451 molecula451 marked this pull request as ready for review May 8, 2020 16:15
@molecula451
Copy link
Contributor Author

Hacked your implementation and spread it across the site my friend @octavioamu :P

@thelostone-mc thelostone-mc merged commit 037aeab into gitcoinco:master May 13, 2020
@octavioamu
Copy link
Contributor

Putting a fix about this PR since was duplicating the user_card.js addition in many places.
Seems this wasn't ready since

  • hackathon pages have other places like participants and projects
  • On tribes just the townsquare is with cards http://localhost:8000/gitcoinco
  • profile pages just the activity was added
  • results page not added
  • and anywhere else a profile shows up on gitcoin

Please submit a new PR with the missing parts (the duplication of user_card is something Im fixing on stable right now)

@molecula451
Copy link
Contributor Author

Putting a fix about this PR since was duplicating the user_card.js addition in many places.
Seems this wasn't ready since

  • hackathon pages have other places like participants and projects
  • On tribes just the townsquare is with cards http://localhost:8000/gitcoinco
  • profile pages just the activity was added
  • results page not added
  • and anywhere else a profile shows up on gitcoin

Please submit a new PR with the missing parts (the duplication of user_card is something Im fixing on stable right now)

Just saw the fixing commit. Submitting a PR asap

@molecula451 molecula451 mentioned this pull request Jun 8, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Take the townsquare user modal, and make it live across the site.
4 participants