Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to render tribes townsquare filters unselected. #6701

Merged
merged 1 commit into from
May 22, 2020

Conversation

androolloyd
Copy link
Contributor

Description

Migrate to use the get_tags helper from townsquare/views

Refers/Fixes
Testing

@androolloyd androolloyd requested a review from octavioamu May 22, 2020 15:23
@androolloyd androolloyd changed the title Fix from all selected filters on tribes. Fix to render tribes townsquare filters unselected. May 22, 2020
@codecov
Copy link

codecov bot commented May 22, 2020

Codecov Report

Merging #6701 into stable will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           stable    #6701   +/-   ##
=======================================
  Coverage   27.12%   27.12%           
=======================================
  Files         292      292           
  Lines       27149    27149           
  Branches     3990     3990           
=======================================
  Hits         7365     7365           
+ Misses      19514    19509    -5     
- Partials      270      275    +5     
Impacted Files Coverage Δ
app/dashboard/views.py 10.93% <0.00%> (ø)
app/quests/views.py 16.22% <0.00%> (ø)
...rketing/management/commands/no_applicants_email.py 0.00% <0.00%> (ø)
...eting/management/commands/assemble_leaderboards.py 40.05% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d11433...dd66b51. Read the comment docs.

@octavioamu octavioamu merged commit a5e0a9c into stable May 22, 2020
thelostone-mc added a commit that referenced this pull request May 27, 2020
* darkmode fix focus textarea

* some small fixes to the quests video backgrounds

* a few dark mode things that the contributor missed

* a few dark mode things that the contributor missed

* hotfix to ensure that the like direction updates the params sent to the server (#6697)

* stopgap for https://gitcoincore.slack.com/archives/CAXQ7PT60/p1590101740315200"

* bug: check if obj is present

* Fix issue with posting to integrated townsquare views. (#6699)

* removing the hidden 'what' variable from the share activity template

* fixes for a poorly named element dic->div, and a fix for posting to integrated townsquares

* fix from having all ask filters enabled at once (#6701)

* broken whitepaper link

* bug: fix posting via hackathon in townsquare

* model changes

Co-authored-by: octavioamu <[email protected]>
Co-authored-by: owocki <[email protected]>
Co-authored-by: Andrew Redden <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants