Fix issue with posting to integrated townsquare views. #6699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
androolloyd
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
Codecov Report
@@ Coverage Diff @@
## master #6699 +/- ##
==========================================
+ Coverage 27.12% 27.13% +0.01%
==========================================
Files 292 292
Lines 27156 27144 -12
Branches 3990 3987 -3
==========================================
Hits 7365 7365
+ Misses 19518 19506 -12
Partials 273 273
Continue to review full report at Codecov.
|
| @@ -572,9 +572,9 @@ | |||
| </div> | |||
| {% if pinned %} | |||
| <div class="pinned-by small mt-2"> | |||
| <dic class="col"> | |||
thelostone-mc
added a commit
that referenced
this pull request
May 27, 2020
* darkmode fix focus textarea * some small fixes to the quests video backgrounds * a few dark mode things that the contributor missed * a few dark mode things that the contributor missed * hotfix to ensure that the like direction updates the params sent to the server (#6697) * stopgap for https://gitcoincore.slack.com/archives/CAXQ7PT60/p1590101740315200" * bug: check if obj is present * Fix issue with posting to integrated townsquare views. (#6699) * removing the hidden 'what' variable from the share activity template * fixes for a poorly named element dic->div, and a fix for posting to integrated townsquares * fix from having all ask filters enabled at once (#6701) * broken whitepaper link * bug: fix posting via hackathon in townsquare * model changes Co-authored-by: octavioamu <[email protected]> Co-authored-by: owocki <[email protected]> Co-authored-by: Andrew Redden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pinned post introduced a regression due to a variable name re-use.
shared/activity.html was including a hidden input that gets passed along, it is failing for hackathons/tribes/anything that uses the shared/activity with the exception of plain townsquare.
Refers/Fixes
No ticket, was found by @connoroday reported via slack
Testing
Please test with Prod data before deploying.