Needs Review - Pinned Post - Site Wide Feature #6680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- available for all activitiy feeds - permissioned (WIP)
- add activity hash
… instead of the border, adding context around who pinned the post, fix for loading the feed correctly
androolloyd
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
Codecov Report
@@ Coverage Diff @@
## master #6680 +/- ##
==========================================
- Coverage 27.13% 27.12% -0.02%
==========================================
Files 291 291
Lines 27033 27115 +82
Branches 3979 3989 +10
==========================================
+ Hits 7335 7354 +19
- Misses 19430 19488 +58
- Partials 268 273 +5
Continue to review full report at Codecov.
|
danlipert
approved these changes
May 20, 2020
There was a problem hiding this comment.
Lets remove the matterbridge file (maybe there are exposed creds here? @androolloyd)
matterbridge.toml
Outdated
| @@ -0,0 +1,27 @@ | |||
| [discord] | |||
There was a problem hiding this comment.
this file seems unrelated
thelostone-mc
approved these changes
May 20, 2020
octavioamu
approved these changes
May 20, 2020
|
Ah let me remove that. Was a hack for vivek |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pinned Posts
Refers/Fixes
#6450
Testing
Screenshot
Gif