Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pin Post Feature #6464

Closed

Conversation

developerfred
Copy link
Contributor

@developerfred developerfred commented Apr 17, 2020

  • Review attached mockup
  • Ensure there can only be one pin per org
  • Add Pin Post menu item in the dropdown after the message has been posted.
  • Use Pin icon from Font Awesome
  • Ensure only the org profile can pin the post and sees the control to pin / unpin
  • Make sure a post can be unpinned
  • Message the tribe chat channel(if ever one) when a post is pinned
  • pin that post to the chat channel
  • blast to the orgs chat townsquare
    Pin Post Feature #6450

Screen

Screen Shot 2020-04-17 at 17 48 59

Feature Gif

pinned_task

Ensure only the org profile can pin the post and sees the control to pin / unpin

tribes-post

@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #6464 into feature/tribes-ts will increase coverage by 0.05%.
The diff coverage is 48.27%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           feature/tribes-ts    #6464      +/-   ##
=====================================================
+ Coverage              27.29%   27.34%   +0.05%     
=====================================================
  Files                    287      287              
  Lines                  26799    26830      +31     
  Branches                3962     3966       +4     
=====================================================
+ Hits                    7315     7337      +22     
- Misses                 19212    19225      +13     
+ Partials                 272      268       -4     
Impacted Files Coverage Δ
app/townsquare/views.py 10.08% <7.69%> (-0.08%) ⬇️
app/townsquare/models.py 58.40% <72.72%> (+0.69%) ⬆️
app/townsquare/admin.py 40.00% <100.00%> (+2.50%) ⬆️
app/avatar/views_3d.py 9.52% <0.00%> (ø)
app/dashboard/views.py 11.04% <0.00%> (ø)
...rketing/management/commands/no_applicants_email.py 0.00% <0.00%> (ø)
...eting/management/commands/assemble_leaderboards.py 40.48% <0.00%> (ø)
app/grants/views.py 16.39% <0.00%> (+0.26%) ⬆️
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45b7dbb...fd17772. Read the comment docs.

@developerfred developerfred force-pushed the issue/6450 branch 8 times, most recently from 5e5b37d to 6d1372b Compare April 17, 2020 23:45
@developerfred developerfred changed the title [WIP]feat: Pin Post Feature feat: Pin Post Feature Apr 22, 2020
@gitcoinbot gitcoinbot mentioned this pull request Apr 22, 2020
10 tasks
@androolloyd
Copy link
Contributor

@PixelantDesign :D

@developerfred developerfred force-pushed the issue/6450 branch 2 times, most recently from 8b9cd3b to 3d7e8c1 Compare April 25, 2020 14:27
@androolloyd androolloyd changed the base branch from master to feature/tribes-ts April 27, 2020 01:19
app/townsquare/models.py Outdated Show resolved Hide resolved
@octavioamu
Copy link
Contributor

Hey @developerfred seems the PR is mixing others commits not related to the task, can you rebase and just keep your commits?

@octavioamu
Copy link
Contributor

My recommendation is to cherrypick your commits into a new PR this one is mixing other people commits since the beginning, not sure what happened here.

Copy link
Contributor Author

@developerfred developerfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @developerfred seems the PR is mixing others commits not related to the task, can you rebase and just keep your commits?

@octavioamu i fixed my pull request, thanks for feedback

app/townsquare/models.py Outdated Show resolved Hide resolved
app/townsquare/models.py Outdated Show resolved Hide resolved
Copy link
Contributor

@PixelantDesign PixelantDesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @developerfred thanks for all of the great work! @androolloyd will bring it in to wrap up the rest for a launch next week. Thank you! I'll pay out for the work.

Copy link
Contributor

@danlipert danlipert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good - just needs a bit of cleanup so the style is on point and the migrations are clean. Please make these fixes and we'll get it in the next deploy 👍

app/retail/templates/shared/activity.html Outdated Show resolved Hide resolved
app/townsquare/migrations/0022_auto_20200501_1436.py Outdated Show resolved Hide resolved
@danlipert danlipert marked this pull request as draft May 18, 2020 14:01
@developerfred
Copy link
Contributor Author

@danlipert fd17772

@developerfred developerfred marked this pull request as ready for review May 18, 2020 16:18
@developerfred developerfred requested a review from danlipert May 18, 2020 16:22
@thelostone-mc
Copy link
Member

@developerfred closing this out as #6680 appends on to what you've built out here! Thanks for helping us get this done ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants