-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Pin Post Feature #6464
feat: Pin Post Feature #6464
Conversation
Codecov Report
@@ Coverage Diff @@
## feature/tribes-ts #6464 +/- ##
=====================================================
+ Coverage 27.29% 27.34% +0.05%
=====================================================
Files 287 287
Lines 26799 26830 +31
Branches 3962 3966 +4
=====================================================
+ Hits 7315 7337 +22
- Misses 19212 19225 +13
+ Partials 272 268 -4
Continue to review full report at Codecov.
|
5e5b37d
to
6d1372b
Compare
efe81de
to
004a9e1
Compare
004a9e1
to
1b45b12
Compare
8b9cd3b
to
3d7e8c1
Compare
3d7e8c1
to
238ecc8
Compare
Hey @developerfred seems the PR is mixing others commits not related to the task, can you rebase and just keep your commits? |
My recommendation is to cherrypick your commits into a new PR this one is mixing other people commits since the beginning, not sure what happened here. |
238ecc8
to
96cf3c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @developerfred seems the PR is mixing others commits not related to the task, can you rebase and just keep your commits?
@octavioamu i fixed my pull request, thanks for feedback
96cf3c4
to
87519f4
Compare
952f965
to
4b55c43
Compare
- add activity hash
4b55c43
to
54db393
Compare
6e8e800
to
53e2414
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @developerfred thanks for all of the great work! @androolloyd will bring it in to wrap up the rest for a launch next week. Thank you! I'll pay out for the work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good - just needs a bit of cleanup so the style is on point and the migrations are clean. Please make these fixes and we'll get it in the next deploy 👍
@developerfred closing this out as #6680 appends on to what you've built out here! Thanks for helping us get this done ^_^ |
Pin Post Feature #6450
Screen
Feature Gif
Ensure only the org profile can pin the post and sees the control to pin / unpin