Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable survey modal if no survey #6544

Merged
merged 2 commits into from
May 1, 2020

Conversation

danlipert
Copy link
Contributor

Description

Disables the hackathon survey modal during onboarding if there is no survey

Refers/Fixes

#6128

Testing

tested locally

@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #6544 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6544   +/-   ##
=======================================
  Coverage   27.30%   27.30%           
=======================================
  Files         287      287           
  Lines       26801    26801           
  Branches     3962     3962           
=======================================
  Hits         7317     7317           
+ Misses      19216    19212    -4     
- Partials      268      272    +4     
Impacted Files Coverage Δ
app/dashboard/views.py 11.04% <0.00%> (ø)
...rketing/management/commands/no_applicants_email.py 0.00% <0.00%> (ø)
...eting/management/commands/assemble_leaderboards.py 40.48% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beb8056...b011671. Read the comment docs.

@danlipert danlipert merged commit 589d38c into master May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants