As a Gitcoin admin, I want an embedded survey for each Gitcoin hackathon so I know the motivations of each hacker #6128

zoek1 · 2020-03-04T11:37:36Z

Description

Add models to build dynamic surveys
Add flow to build a survey from the admin panel

Refers/Fixes

#6087

Testing

DEMO: https://www.loom.com/share/9d95aa6549e54e779e9124959c0a0bb7

Register views

Form to get expectation from the user

The user is registered but the hackathon doesn't start yet

The user is registered but the hackathon already started

Mobile view

codecov · 2020-03-04T11:43:21Z

Codecov Report

Merging #6128 into master will increase coverage by 0.15%.
The diff coverage is 74.02%.

@@            Coverage Diff             @@
##           master    #6128      +/-   ##
==========================================
+ Coverage   27.06%   27.21%   +0.15%     
==========================================
  Files         291      291              
  Lines       26702    26778      +76     
  Branches     3951     3956       +5     
==========================================
+ Hits         7226     7288      +62     
- Misses      19209    19223      +14     
  Partials      267      267

Impacted Files	Coverage Δ
app/dashboard/views.py	`11.12% <5.26%> (-0.08%)`	⬇️
app/dashboard/models.py	`50.09% <90.90%> (+0.34%)`	⬆️
app/dashboard/admin.py	`65.83% <100.00%> (+4.30%)`	⬆️
app/dashboard/embed.py	`31.60% <0.00%> (+3.44%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e9329f...159fca9. Read the comment docs.

…e/hackathon-onboarding

thelostone-mc

@zoek1 checked out the video ! Dope stuff ^_^

Left a bunch of comments + questions
I noticed you had a migration error -> could you rebase with master. -> delete your migration and recreate it. we wanna avoid having merge migration file

app/assets/v2/images/hackathon/heart.svg

app/dashboard/admin.py

app/dashboard/models.py

zoek1 · 2020-04-21T04:03:55Z

@thelostone-mc done!

thelostone-mc

Left a comment on the poll type but otherwise lgtm

zoek1 · 2020-04-22T03:55:00Z

Done @thelostone-mc 👍

PixelantDesign · 2020-04-22T13:52:37Z

The responsive view is not in this PR, could we roll this out and get responsiv view out next week?

zoek1 · 2020-04-22T13:53:15Z

I'll work on the responsive view today, I'll notify here when is done.

danlipert

Looks pretty good - a couple of small improvements id like to see before we merge it in

danlipert · 2020-04-22T13:44:11Z

app/dashboard/templates/dashboard/hackathon/onboard.html

+                </h4>
+                {% else %}
+                <h4 class="font-weight-bolder">
+                  Contratulations! <br> Your registration for  {{ hackathon.name }} is successful.


spelling and spacing as well

danlipert · 2020-04-22T13:45:03Z

app/dashboard/templates/dashboard/hackathon/onboard.html

+                {% endif %}
+                <ul  class="list-unstyled">
+                    <li class="mb-3 gc-text-blue font-weight-bold"><a href="/townsquare?tab=hackathon:{{ hackathon.id }}&trending=0&personal=0"><i class="mr-1 fas fa-check-circle gc-text-blue"></i> Introduce yourself on Town Square + what you like to build (and earn your first Kudos!)</a></li>
+                    <li class="mb-3 gc-text-blue font-weight-bold"><i class="mr-1 fas fa-check-circle gc-text-blue"></i> RSVP our 3 workshops</li>


should be RSVP to our 3 workshops

danlipert · 2020-04-22T13:50:38Z

app/dashboard/views.py

+                    option = Option.objects.get(id=int(entry['value']))
+
+                    try:
+                        Answer.objects.get(user=request.user, question=question, choice=option)


Can use get_or_create here instead https://docs.djangoproject.com/en/3.0/ref/models/querysets/#get-or-create

danlipert · 2020-04-22T13:51:22Z

app/dashboard/views.py

+            set_questions = {}
+            for entry in poll:
+                try:
+                    question = Question.objects.get(id=int(entry['name']))


I'm guessing that you wrapped this is a try/except to catch if these two querysets fail. Lets use get_object_or_404 instead

PixelantDesign · 2020-04-28T12:28:51Z

Thanks for the updates @zoek1! Responsive views look good to me.

The modal on responsive view has different options than the normal view and design spec....could you double check why that is? See your above screenshots:

zoek1 · 2020-04-28T12:52:49Z

@PixelantDesign it's because the questions aren't hardcoded, any of the admins could add, modify, or remove options from the admin panel. In the video demo, I showed how to create options. The question text and the options are dynamics

danlipert · 2020-05-01T13:36:29Z

Hey @zoek1 - after merging this work I spent some additional time testing it and found a lot of issues, so I'm going to disable the popup and tell our staff not to use this functionality until it is fixed and fully tested. Here are some of the problems I found:

Adding multiple questions of each type results in layout issues
Open ended questions do not work
The modal pops up blank if there is no survey

There may be other problems as well as I feel you did not test this thoroughly. Please submit a followup PR that is well tested and fixes these issues - thanks

zoek1 · 2020-05-01T15:39:21Z

@danlipert I mentioned in the video demo that "Open-ended questions" do not work and they don't part of the spec, this is a draft for such type of questions.
Only questions that have multiple options were requested in the bounty, the rest have support only in the backend but not in the frontend that why the issues.
The modal was my error, I thought based on the figma flow all following hackathons should have a survey so don't display the modal wasn't in my flow.
I tested many times the requested flow, and I mentioned what works and what is a draft. have you checked the video before approving the PR? 🤔

danlipert · 2020-05-08T11:19:04Z

@zoek1 I see - in the future, don't include any half-completed features if they don't work properly. You have to consider the end user of this functionality who will not be aware what features work and which don't.

Add models and admin flow to create polls on hackathons events

ad7a95e

zoek1 requested review from danlipert, octavioamu and thelostone-mc as code owners March 4, 2020 11:37

zoek1 added 2 commits April 7, 2020 22:00

Merge branch 'master' of https://github.com/gitcoinco/web into featur…

f5344e9

…e/hackathon-onboarding

Implement sponsors and poll to users before registration

33e1619

zoek1 changed the title ~~WIP: As a Gitcoin admin, I want an embedded survey for each Gitcoin hackathon so I know the motivations of each hacker~~ As a Gitcoin admin, I want an embedded survey for each Gitcoin hackathon so I know the motivations of each hacker Apr 8, 2020

gitcoinbot mentioned this pull request Apr 8, 2020

Hackathon Embedded Registration Flow #6087

Closed

3 tasks

Fix conflicts with master

f9ad5d8

zoek1 added 4 commits April 16, 2020 21:13

Merge branch 'master' into feature/hackathon-onboarding

9546fa8

Fix import error

d15f0bb

Add missed migration

53807c9

Merge branch 'master' into feature/hackathon-onboarding

03c0562

thelostone-mc requested changes Apr 21, 2020

View reviewed changes

zoek1 added 2 commits April 20, 2020 22:37

implement requested changes on hackathon onboarding

702fc6a

Remove robot graphic

44f2276

thelostone-mc reviewed Apr 21, 2020

View reviewed changes

zoek1 added 2 commits April 21, 2020 22:53

Remove type on polls

27c1657

Add migration

18834e7

thelostone-mc approved these changes Apr 22, 2020

View reviewed changes

PixelantDesign approved these changes Apr 22, 2020

View reviewed changes

danlipert suggested changes Apr 22, 2020

View reviewed changes

zoek1 added 3 commits April 28, 2020 02:39

Merge branch 'master' into feature/hackathon-onboarding

d0da8d9

Add responsive styles

91a3de9

Fix migration error

e083b37

zoek1 requested a review from danlipert April 28, 2020 11:06

octavioamu approved these changes Apr 29, 2020

View reviewed changes

Merge branch 'master' into feature/hackathon-onboarding

887734e

danlipert approved these changes Apr 29, 2020

View reviewed changes

Merge branch 'master' into feature/hackathon-onboarding

159fca9

thelostone-mc merged commit 9b48b55 into gitcoinco:master Apr 29, 2020

danlipert mentioned this pull request May 1, 2020

disable survey modal if no survey #6544

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

As a Gitcoin admin, I want an embedded survey for each Gitcoin hackathon so I know the motivations of each hacker #6128

As a Gitcoin admin, I want an embedded survey for each Gitcoin hackathon so I know the motivations of each hacker #6128

zoek1 commented Mar 4, 2020 •

edited

Loading

codecov bot commented Mar 4, 2020 •

edited

Loading

thelostone-mc left a comment

zoek1 commented Apr 21, 2020

thelostone-mc left a comment

zoek1 commented Apr 22, 2020

PixelantDesign commented Apr 22, 2020

zoek1 commented Apr 22, 2020

danlipert left a comment

danlipert Apr 22, 2020

danlipert Apr 22, 2020

danlipert Apr 22, 2020

danlipert Apr 22, 2020

danlipert Apr 22, 2020

PixelantDesign commented Apr 28, 2020

zoek1 commented Apr 28, 2020

danlipert commented May 1, 2020

zoek1 commented May 1, 2020

danlipert commented May 8, 2020

As a Gitcoin admin, I want an embedded survey for each Gitcoin hackathon so I know the motivations of each hacker #6128

As a Gitcoin admin, I want an embedded survey for each Gitcoin hackathon so I know the motivations of each hacker #6128

Conversation

zoek1 commented Mar 4, 2020 • edited Loading

Description

Refers/Fixes

Testing

Register views

Form to get expectation from the user

The user is registered but the hackathon doesn't start yet

The user is registered but the hackathon already started

Mobile view

codecov bot commented Mar 4, 2020 • edited Loading

Codecov Report

thelostone-mc left a comment

Choose a reason for hiding this comment

zoek1 commented Apr 21, 2020

thelostone-mc left a comment

Choose a reason for hiding this comment

zoek1 commented Apr 22, 2020

PixelantDesign commented Apr 22, 2020

zoek1 commented Apr 22, 2020

danlipert left a comment

Choose a reason for hiding this comment

danlipert Apr 22, 2020

Choose a reason for hiding this comment

danlipert Apr 22, 2020

Choose a reason for hiding this comment

danlipert Apr 22, 2020

Choose a reason for hiding this comment

danlipert Apr 22, 2020

Choose a reason for hiding this comment

danlipert Apr 22, 2020

Choose a reason for hiding this comment

PixelantDesign commented Apr 28, 2020

zoek1 commented Apr 28, 2020

danlipert commented May 1, 2020

zoek1 commented May 1, 2020

danlipert commented May 8, 2020

zoek1 commented Mar 4, 2020 •

edited

Loading

codecov bot commented Mar 4, 2020 •

edited

Loading