feature - add flags to leaderboard #6509
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've added functionality to load flag icon next to the country in Community leaderboard
Refers/Fixes
#4152
Testing
Before: https://user-images.githubusercontent.com/21199234/55767457-a3ba4a80-5a96-11e9-8a29-7b1da9e1e30e.png
After:
Personally curated test data 4 countries: https://imgur.com/a/8UQcuSj
If the mapping of Country name to flag fails the default flag is USA e.g Incorrectly spelled Yemen displays US flag https://imgur.com/a/qMRwD15
Real Rinkeby data https://imgur.com/a/KhC84UK
I opted for the flag API instead of emojis as (from my personal research) Microsoft Windows doesn't support flag emojis. Idk, works on my Linux but the userbase of Linux compared to Windows is small.