Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flag to Leaderboard #4152

Closed
aashutoshrathi opened this issue Apr 9, 2019 · 1 comment
Closed

Add Flag to Leaderboard #4152

aashutoshrathi opened this issue Apr 9, 2019 · 1 comment
Labels
easy-pickings This is an easy issue for the community.

Comments

@aashutoshrathi
Copy link
Contributor

aashutoshrathi commented Apr 9, 2019

What

The current leaderboard just has country names with their respective bounties count.
We can make it more user-friendly by adding a flag of the country ahead of their name.

image

Why

It will be convenient for the user to search for the country and will give better UX.

@dzuqe
Copy link
Contributor

dzuqe commented May 23, 2020

@thelostone-mc Hi. I want to point out some issues I found while testing on live site.

  1. I saw it working a few week back but some of the country names are not mapped correctly in the data file. I figured we could extend to a new PR so as to fine tune the render. All that's needed to is to match the country names that gitcoin uses to a country abbreviation in the data file.

  2. I think another commit may have changed the frontend code during a loop so its currently not rendering the flag. I zipped the flags with the items list as I needed a parallel list but now only the items list is being traversed in the loop. I think the name may have been confused. Might be better to rename the list to much more understandable name like items_and_flags
    zipped list not used in loop
    zipped list not used in loop

I will be happy to extend the extra work into a new PR. Anyway, the pull request has been merged, will I receive a tip for this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy-pickings This is an easy issue for the community.
Projects
None yet
Development

No branches or pull requests

3 participants