New As a user, I would like to be able to request money from someon, so I can get paid and remind a forgetful funder. #6411
Conversation
fixes gitcoinco#6136 Add base template for request money Fill tip based on request fund Fix update of requests
…e/request-money
zoek1
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
|
thanks; i'm very excited about this. just put it on the @gitcoinco/engineers PR review board |
|
@zoek1 Does this work with DAI? it seems that it only works for Ether right now |
app/dashboard/tip_views.py
Outdated
| comments = request.POST.get('comments') | ||
| network = request.POST.get('network') | ||
| address = request.POST.get('address') | ||
| token_address = request.POST.get('tokenAddress') |
There was a problem hiding this comment.
Sorry, i forgot delete this unused variable
|
Updated @danlipert
Yes, it works with DAI even with other networks like SIA, or ETC. The 'request payment view' only requires the token name, so the tip view can retrieve the token address. |
Codecov Report
@@ Coverage Diff @@
## master #6411 +/- ##
==========================================
+ Coverage 27.25% 27.29% +0.03%
==========================================
Files 287 287
Lines 26644 26712 +68
Branches 3936 3945 +9
==========================================
+ Hits 7262 7290 +28
- Misses 19115 19155 +40
Partials 267 267
Continue to review full report at Codecov.
|
|
@thelostone-mc could you check this PR please? 😃 |
| _alert('Something goes wrong, try later.', 'error'); | ||
| failure_callback(); | ||
| }); | ||
| } |
There was a problem hiding this comment.
^ could we update all var to const/let?
| <select style="width:100px; margin-bottom: 10px; display: inline;"> | ||
| <option value="{{ fund_request.network }}">{{ fund_request.network }}</option> | ||
| </select> |
There was a problem hiding this comment.
Hey @zoek1 just to let you know here was missing the id="token" so the token select wasn't getting fill.
There was a problem hiding this comment.
Sorry @octavioamu, I'm not sure why the id was missing. I really tested 😧
Description
Refers/Fixes
As a user, I would like to be able to request money from someon, so I can get paid and remind a forgetful funder. #6193
Testing
Demo: https://www.dropbox.com/s/3jmejmc052hyjfy/2020-03-24%2011-56-28.flv?dl=0
Email template
