As a user, I would like to be able to request money from someon, so I can get paid and remind a forgetful funder. #6220

zoek1 · 2020-03-13T09:53:46Z

Description

Refers/Fixes

As a user, I would like to be able to request money from someon, so I can get paid and remind a forgetful funder. #6193

Testing

Demo: https://www.dropbox.com/s/3jmejmc052hyjfy/2020-03-24%2011-56-28.flv?dl=0

Email template

zoek1 · 2020-03-13T09:59:35Z

What happens when a user isn't logged? Should be redirected to the login page? @owocki

owocki · 2020-03-13T15:35:07Z

yes

…

On Fri, Mar 13, 2020 at 3:59 AM Miguel Angel Gordián < ***@***.***> wrote: What happens when a user isn't logged? Should be redirected to the login page? @owocki <https://github.com/owocki> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6220 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAD5PCN3FLM2QSODOVX3OXDRHH7ZNANCNFSM4LG6ZNVQ> .

-- @owocki <http://www.twitter.com/owocki>

_________________________________________ gitcoin is live and has generated over $3.5mm for Open Source Software - see our results <https://gitcoin.co/results>

codecov · 2020-03-24T17:20:04Z

Codecov Report

Merging #6220 into master will increase coverage by 0.65%.
The diff coverage is 24.61%.

@@            Coverage Diff             @@
##           master    #6220      +/-   ##
==========================================
+ Coverage   27.58%   28.23%   +0.65%     
==========================================
  Files         282      278       -4     
  Lines       26116    25459     -657     
  Branches     3847     3726     -121     
==========================================
- Hits         7203     7189      -14     
+ Misses      18649    17989     -660     
- Partials      264      281      +17

Impacted Files	Coverage Δ
app/app/urls.py	`91.07% <ø> (+4.63%)`	⬆️
app/retail/emails.py	`22.48% <28.57%> (+0.14%)`	⬆️
app/dashboard/tip_views.py	`14.56% <8.57%> (-0.86%)`	⬇️
app/dashboard/models.py	`50.57% <83.33%> (+0.76%)`	⬆️
app/marketing/mails.py	`11.98% <9.09%> (+0.19%)`	⬆️
app/grants/clr.py	`0% <0%> (-13.7%)`	⬇️
app/avatar/models.py	`38.55% <0%> (-2.59%)`	⬇️
app/avatar/admin.py	`78.57% <0%> (-1.87%)`	⬇️
app/grants/models.py	`47.69% <0%> (-1.85%)`	⬇️
app/marketing/models.py	`62.71% <0%> (-1.34%)`	⬇️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 850bd78...c6ffa0b. Read the comment docs.

owocki · 2020-04-06T17:37:13Z

app/assets/onepager/js/request.js

+  $('#request').on('click', function(e) {
+    e.preventDefault();
+    if ($(this).hasClass('disabled'))
+      return;


you need to validate that the user has accepted the TOS

owocki · 2020-04-06T17:37:38Z

app/dashboard/models.py

@@ -1773,6 +1773,26 @@ def __str__(self):
        return f"tip: {self.tip.pk} profile: {self.profile.handle}"


+class FundRequest(SuperModel):


can you add this model to dashboard/admin

owocki · 2020-04-06T17:38:45Z

app/dashboard/migrations/0093_auto_20200324_1653.py

+import economy.models
+
+
+class Migration(migrations.Migration):


CommandError: Conflicting migrations detected; multiple leaf nodes in the migration graph: (0093_auto_20200324_1653, 0095_hackathonevent_visible in dashboard). To fix them run 'python manage.py makemigrations --merge'

we are avoiding "merge" on this cases where the migration is on a Pr need to be deleted and recreated.

owocki · 2020-04-06T17:39:48Z

@zoek1 just left a few small comments. looking really good! this will save a lot of time and heartache and reduce miscommunication i think

@danlipert @gitcoinco/engineers any chance this can get an 👀 pls?

owocki · 2020-04-06T17:45:50Z

looks great; very impressive art AND you read the instructions and delivered an svg that matches the spec :) yay!!!

anything i should put in your bio on-site for delivering this avatar?

owocki · 2020-04-06T17:58:14Z

shit i hit merge on the wrong PR (this one). here is a PR that reverts my merge #6386

octavioamu · 2020-04-06T18:12:00Z

@zoek1 now this was reverted, can you recreate this PR ?

zoek1 · 2020-04-06T18:21:33Z

Sure @Octavio, also i'll add the requests changes 🙂

owocki · 2020-04-06T18:22:00Z

ok heres a new PR we can use #6220

unless you want to do it again off ur PR @zoek1 ? sorry again about this.

zoek1 · 2020-04-07T10:01:00Z

No problem :) I'm finishing another task for the hackathon view and after that, I'll add the requested changes here

owocki · 2020-04-08T19:03:06Z

@zoek1 can you link the new PR here? im keen to get this live sono!

owocki · 2020-04-08T19:03:08Z

*soon

zoek1 · 2020-04-09T02:53:17Z

Working on it right now, I think in a couple of hours it will be finished 😄

zoek1 · 2020-04-09T07:03:05Z

New PR @owocki #6411

owocki · 2020-04-09T14:06:38Z

thanks :)

…

On Thu, Apr 9, 2020 at 1:03 AM Miguel Angel Gordián < ***@***.***> wrote: New PR @owocki <https://github.com/owocki> #6411 <#6411> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6220 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAD5PCOBAY3SZKS5MKDOL5DRLVXLPANCNFSM4LG6ZNVQ> .

-- @owocki <http://www.twitter.com/owocki>

_________________________________________ gitcoin is live and has generated over $4.0mm for Open Source Software - see our results <https://gitcoin.co/results>

zoek1 requested review from danlipert, octavioamu and thelostone-mc as code owners March 13, 2020 09:53

zoek1 added 2 commits March 24, 2020 05:58

Add base template for request money

78ab27a

Fill tip based on request fund

511a31b

zoek1 force-pushed the feature/request-money branch from ee16b8d to 511a31b Compare March 24, 2020 17:20

zoek1 changed the title ~~WIP: As a user, I would like to be able to request money from someon, so I can get paid and remind a forgetful funder.~~ As a user, I would like to be able to request money from someon, so I can get paid and remind a forgetful funder. Mar 24, 2020

zoek1 added 2 commits March 24, 2020 12:17

Fix update of requests

eb4a52e

Merge branch 'master' into feature/request-money

c6ffa0b

zoek1 mentioned this pull request Apr 1, 2020

As a user, I would like to be able to request money from someon, so I can get paid and remind a forgetful funder. #6193

Closed

owocki reviewed Apr 6, 2020

View reviewed changes

owocki merged commit a8007e0 into gitcoinco:master Apr 6, 2020

owocki mentioned this pull request Apr 6, 2020

Revert "As a user, I would like to be able to request money from someon, so I can get paid and remind a forgetful funder." #6386

Merged

owocki mentioned this pull request Apr 6, 2020

Recreation of #6220 which was accidently merged #6387

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

As a user, I would like to be able to request money from someon, so I can get paid and remind a forgetful funder. #6220

As a user, I would like to be able to request money from someon, so I can get paid and remind a forgetful funder. #6220

zoek1 commented Mar 13, 2020 •

edited

Loading

zoek1 commented Mar 13, 2020

owocki commented Mar 13, 2020 via email

codecov bot commented Mar 24, 2020 •

edited

Loading

owocki Apr 6, 2020

owocki Apr 6, 2020

owocki Apr 6, 2020

octavioamu Apr 6, 2020

owocki commented Apr 6, 2020

owocki commented Apr 6, 2020

owocki commented Apr 6, 2020

octavioamu commented Apr 6, 2020

zoek1 commented Apr 6, 2020

owocki commented Apr 6, 2020

zoek1 commented Apr 7, 2020

owocki commented Apr 8, 2020

owocki commented Apr 8, 2020

zoek1 commented Apr 9, 2020

zoek1 commented Apr 9, 2020

owocki commented Apr 9, 2020 via email

		@@ -1773,6 +1773,26 @@ def __str__(self):
		return f"tip: {self.tip.pk} profile: {self.profile.handle}"


		class FundRequest(SuperModel):

As a user, I would like to be able to request money from someon, so I can get paid and remind a forgetful funder. #6220

As a user, I would like to be able to request money from someon, so I can get paid and remind a forgetful funder. #6220

Conversation

zoek1 commented Mar 13, 2020 • edited Loading

Description

Refers/Fixes

Testing

zoek1 commented Mar 13, 2020

owocki commented Mar 13, 2020 via email

codecov bot commented Mar 24, 2020 • edited Loading

Codecov Report

owocki Apr 6, 2020

Choose a reason for hiding this comment

owocki Apr 6, 2020

Choose a reason for hiding this comment

owocki Apr 6, 2020

Choose a reason for hiding this comment

octavioamu Apr 6, 2020

Choose a reason for hiding this comment

owocki commented Apr 6, 2020

owocki commented Apr 6, 2020

owocki commented Apr 6, 2020

octavioamu commented Apr 6, 2020

zoek1 commented Apr 6, 2020

owocki commented Apr 6, 2020

zoek1 commented Apr 7, 2020

owocki commented Apr 8, 2020

owocki commented Apr 8, 2020

zoek1 commented Apr 9, 2020

zoek1 commented Apr 9, 2020

owocki commented Apr 9, 2020 via email

zoek1 commented Mar 13, 2020 •

edited

Loading

codecov bot commented Mar 24, 2020 •

edited

Loading